Conversation
dariakp
requested changes
Apr 16, 2025
Contributor
|
Capturing from our meeting: we want to get the keepAlive related options into the "options" argument we pass into KeepAlive will still always be enabled and not configurable. |
durran
commented
Apr 23, 2025
durran
commented
Apr 23, 2025
nbbeeken
requested changes
Apr 23, 2025
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
durran
commented
Apr 23, 2025
dariakp
requested changes
Apr 23, 2025
dariakp
requested changes
Apr 23, 2025
dariakp
approved these changes
Apr 23, 2025
nbbeeken
approved these changes
Apr 23, 2025
Contributor
nbbeeken
left a comment
There was a problem hiding this comment.
LGTM (I'll get a ping when the CI finishes)
Contributor
Author
|
Failures look all like the FLE bad uri test that has the slack thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brings back the
keepAliveInitialDelayoption.What is changing?
keepAliveInitialDelayas an option to pass to the socket.setKeepAliveandsetNoDelayIs there new documentation needed for these changes?
Yes, driver docs.
What is the motivation for this change?
NODE-6245
Release Highlight
keepAliveInitialDelaymay now be configured at theMongoClientlevelWhen not present will default to 120 seconds. The option value must be specified in milliseconds.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript