fix(NODE-6764): incorrect negative bigint handling#752
Merged
baileympearson merged 7 commits intomainfrom Feb 19, 2025
Merged
Conversation
W-A-James
changed the title
rkistner
approved these changes
Feb 19, 2025
rkistner
left a comment
rkistner
left a comment
There was a problem hiding this comment.
Thanks for the quick fix! The change looks good to me, and should fix the issue I had
durran
suggested changes
Feb 19, 2025
test/node/bigint.test.ts
Outdated
| it(description, test); | ||
| } | ||
|
|
||
| describe('edge case tests', function () { |
Contributor
There was a problem hiding this comment.
Just a little nit. Instead of just calling these edge case tests can we better describe what we are testing here? I'd personally prefer individual it blocks with specific descriptions than the generic describe and loop.
durran
added
the
Primary Review
nbbeeken
requested changes
Feb 19, 2025
nbbeeken
approved these changes
Feb 19, 2025
nbbeeken
pushed a commit
that referenced
this pull request
Mar 5, 2025
W-A-James
added a commit
that referenced
this pull request
Mar 6, 2025
W-A-James
added a commit
that referenced
this pull request
Mar 6, 2025
baileympearson
pushed a commit
that referenced
this pull request
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Correct regression to bigint deserialziation introduced in #649
What is changing?
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
useBigInt64is enabledAfter refactoring to improve deserialization performance in #649, we inadvertently introduced a bug that manifested when deserializing
Longvalues with theuseBigInt64flag enabled. The bug would lead to negativeLongvalues being deserialized as unsigned integers. This issue has been resolved here.Thanks to @rkistner for reporting this bug!
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript