Merged
Conversation
ffb41a1 to
290b9ce
Compare
290b9ce to
05ad18c
Compare
W-A-James
suggested changes
Mar 5, 2024
W-A-James
previously approved these changes
Mar 6, 2024
Contributor
aditi-khare-mongoDB
left a comment
There was a problem hiding this comment.
LGTM, left a few clarifying comments
baileympearson
previously requested changes
Mar 6, 2024
W-A-James
reviewed
Mar 7, 2024
W-A-James
previously approved these changes
Mar 7, 2024
W-A-James
approved these changes
Mar 7, 2024
Concerns addressed and go-ahead to merge given via slack
This was referenced May 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Algorithm
Is there new documentation needed for these changes?
There is TS doc marking the new APIs as
@experimentalWhat is the motivation for this change?
This API is intended to be a building block for unlocking optimizations around lazily parsing BSON.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript