Conversation
W-A-James
suggested changes
Aug 2, 2023
Contributor
W-A-James
left a comment
There was a problem hiding this comment.
You're getting failures in CI because we have tests for what seems to be all of our BSON types that check for the @@mdb.bson.version flag that are failing to match the new value.
W-A-James
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps
BSON_MAJOR_VERSIONconstant to 6.What is changing?
Bumps
BSON_MAJOR_VERSIONconstant to 6 and adds a test.Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-5504
Release Highlight
BSON_MAJOR_VERSIONbumped to 6Only BSON objects that have this major version can be serialized with this version of the library. Mismatched objects will throw a
BSONVersionErrorwhen attempting to serialize.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript