fix(NODE-4887): serializeInto does not check for the presence of a toBSON method for values in Map entries#555
Merged
baileympearson merged 3 commits intomainfrom Jan 9, 2023
Conversation
W-A-James
force-pushed
the
NODE-4887/serializeInto_does_not_check_for_toBSON_method_for_map_entries
branch
from
6deae7c to
6de6fdb
Compare
baileympearson
requested changes
Jan 9, 2023
Contributor
baileympearson
left a comment
baileympearson
left a comment
There was a problem hiding this comment.
Looks good, one small test wording suggestion. I'm requesting changes for visibility but otherwise LGTM
Co-authored-by: Bailey Pearson <bailey.pearson@mongodb.com>
baileympearson
approved these changes
Jan 9, 2023
baileympearson
deleted the
NODE-4887/serializeInto_does_not_check_for_toBSON_method_for_map_entries
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding fix to ensure that values of
Maps run are replaced by the result of calling theirtoBSONmethod if it exists.Is there new documentation needed for these changes?
No
What is the motivation for this change?
Ensure that
BSON.serializekeeps with spec behaviourDouble check the following
npm run lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript