fix: Fix backwards compatibility with older BSON package versions#411
Merged
fix: Fix backwards compatibility with older BSON package versions#411
Conversation
The isBuffer check in the buffer module was too strict and led to a failure to deal with older BSON module Binary types. There is now an improved more relaxed method. NODE-2848
emadum
approved these changes
Nov 16, 2020
Contributor
emadum
left a comment
emadum
left a comment
There was a problem hiding this comment.
LGTM, just one comment request 👍
| @@ -0,0 +1,74 @@ | |||
| 'use strict'; | |||
Contributor
There was a problem hiding this comment.
I think a comment block somewhere at the top of this file would be useful to future maintainers, explaining what it is doing and why it's needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The isBuffer check in the buffer module was too strict and led to a failure to deal with older BSON module Binary types. There is now an improved more relaxed method.
NODE-2848
I added testing for this, we can easily expand it to cover more types/cases with older versions of the library.