DOCSP-46221: Atlas SDK for Go Monitoring & Logging scripts for Atlas Architecture Center #33
Conversation
| @@ -0,0 +1,69 @@ | |||
| // :snippet-start: config-loader-function-full-example | |||
There was a problem hiding this comment.
Maybe you can reuse instead env-var names from Terraform function:
func setDefaultValuesWithValidations(ctx context.Context, data *tfMongodbAtlasProviderModel, resp *provider.ConfigureResponse) tfMongodbAtlasProviderModel {
This way it is easier for users to transition between tools
| ) | ||
|
|
||
| type Config struct { | ||
| AtlasBaseURL string `json:"ATLAS_BASE_URL"` |
There was a problem hiding this comment.
Usually, it is simpler to only use the MONGODB_ATLAS_BASE_URL than using hostname, port, etc.
cbullinger
force-pushed
the
docsp-46221
branch
4 times, most recently
from
fb5d475 to
79ae2df
Compare
dacharyc
left a comment
dacharyc
left a comment
There was a problem hiding this comment.
Nice work on this! It's a big deliverable in a new problem domain for our team, with some added complications re: snippets/copied app. I think you've done a great job of breaking it all down here.
I've got a handful of nitpicks, style questions, and minor suggestions, and one issue re: imports in the generated app copy that is preventing it from compiling unless I manually delete them. Marking this PR as "request changes" only because of that issue; everything else is a suggestion/nitpick/subjective.
generated-usage-examples/go/atlas-sdk-go/project-copy/internal/logs/fetch_test.go
Outdated
Show resolved
Hide resolved
| go run cmd/get_logs/main.go | ||
| ``` | ||
|
|
||
| ## Set up |
There was a problem hiding this comment.
Just a Q - should this Set up section also be in the public README? Seems it would be useful to give folks info about the service account prereq, and info about where/how to set env variables and config file information.
There was a problem hiding this comment.
Re. this and following comment, I do have a version of this content in the public README draft, but I'll include it in a separate PR. I didn't want it to keep me from dragging this PR out even longer 😓
dacharyc
left a comment
dacharyc
left a comment
There was a problem hiding this comment.
Awesome work with the updates. This is looking good. LGTM! 🚢
DOCSP-46221: Atlas SDK for Go Monitoring & Logging scripts for Atlas Architecture Center
3 participants
Jira Ticket
DOCSP-46221
Description of Changes
IA Changes
/goand/javato support multiple sub-directoriesAtlas SDK for Go
/go/atlas-sdk-goprojectTODO (outside of this ticket)