feat: add support for an S3 client via host interface. support PUT/GET for now. #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerburdsall
requested review from
PDXKimani,
anitarua,
jlapier,
kvcache and
malandis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
PutObjectandGetObjectvia a host-managed interface for an S3 client. This allows you to have a long-lasting client and avoid reconstructing a brand new S3 client even if it's been days since you've last invoked your function. The included examples merely show a simple ingest/egress function, but naturally you could pair this with Momento caches to avoid extra S3 calls if need be.