Remove the thread pool from sync caches
#316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `scheduled-thread-pool` crate.
- Remove `thread_pool` and `unsafe_weak_pointers` modules.
- Remove notification `DeliveryMode` as now `sync` caches only support the
`Immediate` mode (like `future::Cache`).
- Remove `sync::ConcurrentCacheExt`.
- Rename `sync::ConcurrentCacheExt::sync` method to
`sync::{Cache, SegmentedCache}::run_pending_tasks`.
- Make compilation to fail if none of `sync` and `future` features are enabled. - Update the migration guide. - Change the interval of auto running pending tasks from 500 ms to 300 ms.
Fix the CI.
Update the doc comments.
Fix a lock related bug in `run_pending_tasks` of `sync` housekeeper.
Some clean up.
This was referenced Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the followings on
sync::Cacheandsync::SegmentedCache:syncfrom the default features. Nowsynccaches are disabled by default.notification::DeliveryModeenum for eviction listener.DeliveryMode::Immediateis specified.For more details, see the migration guide.