Remove unit-casting #4158
Merged
Remove unit-casting #4158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansOlsson
added
the
L: Magnetic.FluxTubes
…Gain.k had unit 1
HansOlsson
added
L: Electrical.Machines
Contributor
Author
|
Also removed unitFrequency for similar cases. |
hubertus65
approved these changes
Oct 27, 2023
Contributor
|
@christiankral can you review the changes , Thanks . |
christiankral
approved these changes
Dec 4, 2023
Contributor
christiankral
left a comment
christiankral
left a comment
There was a problem hiding this comment.
This PR looks good to me.
Contributor
|
@HansOlsson Is there way to savely remove the "ghosting" constants by means of a conversion script? If yes, we should open a ticket to not forget about it in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove use of unitK and unitH and instead use proper units.
(Keeping them just in case.)
Part is related #4053 - other part mean that we get Resistance as input to the variable Resistance - which makes sense to me.
Based on comment in #4053 is should be an issue for Thomas Boedrich and Johannes Ziske - but I couldn't find the latter and the former had latest activity in 2020.