Skip to content

Fix unit error in TestOnly.MoistAir, R134a_setState_pTX and WaterIF97_dewEnthalpy #4114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 14, 2024
Merged

Fix unit error in TestOnly.MoistAir, R134a_setState_pTX and WaterIF97_dewEnthalpy #4114

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
edf832c
Fix unit error in TestOnly.MoistAir
henrikt-ma Apr 6, 2023
96589ae
Fix R134a_setState_pTX and WaterIF97_dewEnthalpy in the same way
henrikt-ma Apr 6, 2023
bce24db
Merge remote-tracking branch 'central/master' into testonly-moistair-…
henrikt-ma Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ModelicaTest/Media.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,7 +919,9 @@ is given to compare the approximation.
extends Modelica.Icons.Example;
package Medium = Modelica.Media.Air.MoistAir "Medium model";
SI.Temperature T = 273.15 + 100;
SI.AbsolutePressure p = 2e5 - 1.5e5*time;
parameter SI.AbsolutePressure p0 = 2e5 "p at time 0";
parameter Real pRate(unit = "Pa/s") = -1.5e5 "p's rate of change";
SI.AbsolutePressure p = p0 + pRate*time;
Medium.MassFraction X[Medium.nX] = {0.05,0.95};
Medium.ThermodynamicState state = Medium.setState_pTX(p,T,X);
SI.SpecificEntropy s = Medium.specificEntropy(state);
Expand All @@ -932,7 +934,9 @@ is given to compare the approximation.
extends Modelica.Icons.Example;
replaceable package Medium = Modelica.Media.R134a.R134a_ph "Medium model";
SI.Temperature T = 273.15 + 25;
SI.AbsolutePressure p = 10e5 + 20e5*time;
parameter SI.AbsolutePressure p0 = 10e5 "p at time 0";
parameter Real pRate(unit = "Pa/s") = 20e5 "p's rate of change";
SI.AbsolutePressure p = p0 + pRate*time;
Medium.ThermodynamicState state = Medium.setState_pTX(p, T);
SI.SpecificEnthalpy h = Medium.specificEnthalpy(state);
SI.Density rho = Medium.density(state);
Expand All @@ -946,7 +950,9 @@ is given to compare the approximation.
extends Modelica.Icons.Example;
replaceable package Medium = Modelica.Media.Water.WaterIF97_fixedregion "Medium model";
SI.Temperature T = 273.15 + 25;
SI.AbsolutePressure p = 10e5 + 20e5*time;
parameter SI.AbsolutePressure p0 = 10e5 "p at time 0";
parameter Real pRate(unit = "Pa/s") = 20e5 "p's rate of change";
SI.AbsolutePressure p = p0 + pRate*time;
Medium.ThermodynamicState state = Medium.setState_pTX(p, T);
SI.SpecificEnthalpy h_dew = Medium.dewEnthalpy(Medium.SaturationProperties(Tsat=Medium.saturationTemperature(state.p), psat=Medium.pressure(state)));
annotation (experiment(StopTime=1));
Expand Down