Skip to content

Fix unit error in TestOnly.MoistAir, R134a_setState_pTX and WaterIF97_dewEnthalpy #4114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 14, 2024
Merged

Fix unit error in TestOnly.MoistAir, R134a_setState_pTX and WaterIF97_dewEnthalpy #4114

merged 3 commits into from
Jan 14, 2024

Conversation

@henrikt-ma
Copy link
Contributor

@henrikt-ma henrikt-ma commented Apr 6, 2023

Note that there is currently no Units.SI.PressureRate. In case #4103 gets merged first, we should make use of the Units.SI.PressureRate introduced there.

@henrikt-ma
Fix unit error in TestOnly.MoistAir
edf832c 
Note that there is currently no Units.SI.PressureRate.
@henrikt-ma henrikt-ma added L: Media Issue addresses Modelica.Media L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined labels Apr 6, 2023
@henrikt-ma henrikt-ma changed the title Fix unit error in TestOnly.MoistAir Fix unit error in TestOnly.MoistAir, R134a_setState_pTX and WaterIF97_dewEnthalpy Apr 6, 2023
@qlambert-pro
Copy link
Contributor

qlambert-pro commented Apr 6, 2023

This would help addressing the issues reported in #4099

@HansOlsson
Copy link
Contributor

HansOlsson commented Apr 11, 2023

I'm not sure if this is needed - and would discuss it together with #4097

HansOlsson
HansOlsson previously requested changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here as well.

@henrikt-ma
Copy link
Contributor Author

henrikt-ma commented Jun 30, 2023

And here as well.

I think you need to elaborate.

@HansOlsson
Copy link
Contributor

HansOlsson commented Oct 25, 2023

And here as well.

I think you need to elaborate.

See comments in #4103 and #4117

@hubertus65 hubertus65 dismissed HansOlsson’s stale review November 14, 2023 14:41

Has been decided in meeting on 2023-11-14 to merge with proposed fixes.

@hubertus65 hubertus65 requested a review from casella November 14, 2023 14:42
@beutlich beutlich requested review from casella and removed request for casella November 14, 2023 17:31
@HansOlsson HansOlsson self-requested a review November 15, 2023 09:21
HansOlsson
HansOlsson approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, according to MAP-Lib.

@henrikt-ma henrikt-ma added this to the MSL4.1.0 milestone Dec 12, 2023
@arunkumar-narasimhan arunkumar-narasimhan merged commit 2518ca1 into modelica:master Jan 14, 2024
@beutlich beutlich removed the request for review from casella January 14, 2024 19:31
@beutlich beutlich removed the L: Media Issue addresses Modelica.Media label Jan 14, 2024
@henrikt-ma henrikt-ma deleted the testonly-moistair-unit-error branch January 15, 2024 08:07
@qlambert-pro qlambert-pro mentioned this pull request Apr 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HansOlsson HansOlsson HansOlsson approved these changes

@hubertus65 hubertus65 hubertus65 approved these changes

Assignees

No one assigned

Labels

L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined

Projects

None yet

Milestone

MSL4.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@henrikt-ma @qlambert-pro @HansOlsson @hubertus65 @beutlich @arunkumar-narasimhan