-
Notifications
You must be signed in to change notification settings - Fork 176
Fix unit error in SimpleLiquidWater model #4103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit error in SimpleLiquidWater model #4103
Conversation
Co-authored-by: Hans Olsson <[email protected]>
|
I believe the important part for that test-case isn't unit-checking, but some explanation for the Example itself. Here we have two "volumes" one where we have a constant enthalpy inflow and another where we sweep the pressure. And then we mix their states around 30+/-10 s when simulating from 0 to 100s. At least that's what I can see from the model, but it still doesn't answer: Why? As for the model after the proposed changes: Note that the other examples in that package often run from 0 to 1s instead of 100s as in this example; so a parameter for pressure-rate is not that understandable on its own. On other hand there is an EnthalpyFlowRate for the other volume, and the change of pressure wasn't easier to understand in the original model. |
HansOlsson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As indicated before I think the major issue is understanding the example, and the change doesn't help. It's also an unresolved question exactly how forgiving we should be for test-cases like this.
The following would make it more understandable IMO:
- Explain that we sweep pressure to show something (I'm no fluid expert!)
- We specifically sweep the pressure from 0 to 10bar for 100s; that seems more understandable than pressureRate so we might as well use that parametrization and thus avoid a new type.
- We might as well have it as parameter instead of constant.
Co-authored-by: Henrik Tidefelt <[email protected]>
HansOlsson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, since Hubertus likes it. (Note that I haven't requested changes before on this one.)

This PR is meant to address some of the issues reported in #4099. If the opinions are positive I can prepare a larger patch set fixing them all.