Propose better unit-handling in equation for LogSweep #4055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
BTW: Looking at the uses of the model, should wMin and wMax also be declared as frequencies corresponding to their description? I understand that it can technically sweep anything, but if the intent is that they are frequencies that would be helpful as documentation. |
casella
approved these changes
Nov 2, 2022
Contributor
casella
left a comment
casella
left a comment
There was a problem hiding this comment.
I completely agree with this proposal. From a numerical point of view of course log(xy) = log(x) + log(y), if x>0 and y > 0, that is. However, from a physical point of view, the argument of transcendental functions in physical laws should be dimensionless. So, if we want to use variables with units, the proposed change is much better.
christiankral
approved these changes
Nov 15, 2022
Contributor
christiankral
left a comment
christiankral
left a comment
There was a problem hiding this comment.
I also very much agree with this proposal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in the documentation rewrite to make it easier for unit-checking.
Previously the equation contained
10^(log10(wMin)+(log10(wMax)-log(wMin))*x)but that is replaced by the equivalent towMin*(wMax/wMin)^x.Looking at units for the first equation would require some special logic, but the second trivially has the same unit as wMin.