Skip to content

Remove unit error changing #4041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Remove unit error changing #4041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf30cb7
Remove unit errors.
HansOlsson Sep 30, 2022
97905bb
Avoid unit error.
HansOlsson Sep 30, 2022
ccb3636
Fix incorrect start-value.
HansOlsson Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Modelica/Electrical/Machines/Examples/ControlledDCDrives/Utilities/DcdcInverter.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ model DcdcInverter "DC-DC inverter"
k=1,
T=Tmf,
initType=Modelica.Blocks.Types.Init.InitialOutput,
y_start=VMax)
y_start=0)
annotation (Placement(transformation(extent={{60,50},{80,70}})));
equation
connect(iMotSensor.p, pin_nMot) annotation (Line(points={{-50,-80},{
Expand Down
4 changes: 3 additions & 1 deletion Modelica/Electrical/Machines/Examples/ControlledDCDrives/Utilities/IdealDcDc.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ model IdealDcDc "Ideal DC-DC inverter"
Modelica.Blocks.Continuous.Integrator powerController(
initType=Modelica.Blocks.Types.Init.InitialOutput,
y_start=0,
k=1/Ti) annotation (Placement(transformation(extent={{30,10},{10,30}})));
k=1/Ti/unitVoltage) annotation (Placement(transformation(extent={{30,10},{10,30}})));
Modelica.Electrical.Analog.Basic.Ground groundMotor annotation (Placement(
transformation(
extent={{-10,10},{10,-10}},
Expand All @@ -45,6 +45,8 @@ model IdealDcDc "Ideal DC-DC inverter"
annotation (Placement(transformation(extent={{90,-112},{110,-92}})));
Modelica.Blocks.Interfaces.RealInput vRef
annotation (Placement(transformation(extent={{-140,-20},{-100,20}})));
protected
constant SI.Voltage unitVoltage=1 annotation(HideResult=true);
equation
connect(signalCurrent.p, powerBat.nc)
annotation (Line(points={{10,70},{20,70}}, color={0,0,255}));
Expand Down
3 changes: 1 addition & 2 deletions Modelica/Electrical/Machines/Examples/SynchronousMachines/SMEE_LoadDump.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,7 @@ model SMEE_LoadDump
extent={{-10,-10},{10,10}},
rotation=270,
origin={30,-50})));
Modelica.Blocks.Math.Gain setPointGain(k=(smeeData.VsNominal/wNominal)/
unitMagneticFlux)
Modelica.Blocks.Math.Gain setPointGain(k=(smeeData.VsNominal/wNominal))
annotation (Placement(transformation(extent={{-50,-90},{-70,-70}})));
Machines.Sensors.VoltageQuasiRMSSensor voltageQuasiRMSSensor(ToSpacePhasor1(y(
each start=1E-3, each fixed=true))) annotation (Placement(
Expand Down
3 changes: 1 addition & 2 deletions ...lica/Magnetic/FundamentalWave/Examples/BasicMachines/SynchronousMachines/SMEE_LoadDump.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,7 @@ model SMEE_LoadDump
extent={{-10,-10},{10,10}},
rotation=270,
origin={30,-50})));
Modelica.Blocks.Math.Gain setPointGain(k=(smeeData.VsNominal/wNominal)/
unitMagneticFlux)
Modelica.Blocks.Math.Gain setPointGain(k=(smeeData.VsNominal/wNominal))
annotation (Placement(transformation(extent={{-50,-90},{-70,-70}})));
Modelica.Electrical.Machines.Sensors.VoltageQuasiRMSSensor voltageQuasiRMSSensor(
ToSpacePhasor1(y(each start=1E-3, each fixed=true))) annotation (
Expand Down