Remove unit error changing #4041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to modelica#3881 These changes are completely safe.
Adding a protected element in an example model should be ok.
Detected due to unit-checking.
HansOlsson
added
bug
beutlich
added
L: Magnetic.FundamentalWave
christiankral
approved these changes
Oct 17, 2022
Contributor
christiankral
left a comment
christiankral
left a comment
There was a problem hiding this comment.
Looks good from my side
Contributor
Contributor
|
As a simulation example does not have to be backwards compatible there is no reason to keep it backwards compatible. |
AHaumer
approved these changes
Nov 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It builds on #4040
There is only one new commit here (the latest one); it might be better to cherry-pick - but this combined PR ensures that there are no unit-errors in the library.
This commit changes a start-value and actually changes the simulation results for the example as follows.
Simulating Modelica.Electrical.Machines.Examples.ControlledDCDrives.SpeedControlledDCPM we get:
The blue line indicates that previously the inverter started with a current of 120A and then quickly settled at 0A, now it starts at 0A. The start-value was VMax - which doesn't make sense for a current; I believe it was copied from the voltage-controller-component.
I believe we should consider also back-porting this to the maintenance-branch.