Revert major part of #227, and remove unit from gain parameter of Modelica.Blocks.Continuous.* blocks and Modelica.Blocks.Math.Gain #3881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you want unit="1" for a gain-block, add parameter with unit="1" as in the updated test-case. Closes modelica#3878
dietmarw
approved these changes
Oct 14, 2021
Member
dietmarw
left a comment
dietmarw
left a comment
There was a problem hiding this comment.
I think this is the cleaner way to resolve the issue.
christiankral
approved these changes
Oct 28, 2021
Contributor
christiankral
left a comment
christiankral
left a comment
There was a problem hiding this comment.
I think this is a sound solution now.
MartinOtter
approved these changes
Oct 29, 2021
beutlich
added
the
L: ModelicaTest
beutlich
changed the title
beutlich
changed the title
HansOlsson
added a commit
to HansOlsson/Modelica
that referenced
this pull request
Sep 30, 2022
This is related to modelica#3881 These changes are completely safe.
This was referenced Sep 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ccompare with af01213
If you want unit="1" for a gain-block, add parameter with unit="1" as in the updated test-case.
Closes #3878