Skip to content

Commit 7fcde12

Browse files
CopilotCopilot
andcommitted
Strengthen Assert.NotNull(deserialized.Meta) to validate actual content
Replace weak Assert.NotNull(deserialized.Meta) assertions with proper content validation in all 40 Protocol test files. Each assertion now verifies the actual key-value pair set in the test's Meta property. Co-authored-by: Copilot <[email protected]>
1 parent 76fbe3f commit 7fcde12

40 files changed

+40
-0
lines changed

tests/ModelContextProtocol.Tests/Protocol/CallToolRequestParamsTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ public static void CallToolRequestParams_SerializationRoundTrip_PreservesAllProp
3333
Assert.NotNull(deserialized.Task);
3434
Assert.Equal(original.Task.TimeToLive, deserialized.Task.TimeToLive);
3535
Assert.NotNull(deserialized.Meta);
36+
Assert.Equal("token-123", (string)deserialized.Meta["progressToken"]!);
3637
}
3738

3839
[Fact]

tests/ModelContextProtocol.Tests/Protocol/CallToolResultTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ public static void CallToolResult_SerializationRoundTrip_PreservesAllProperties(
3737
Assert.NotNull(deserialized.Task);
3838
Assert.Equal("task-1", deserialized.Task.TaskId);
3939
Assert.NotNull(deserialized.Meta);
40+
Assert.Equal("value", (string)deserialized.Meta["key"]!);
4041
}
4142

4243
[Fact]

tests/ModelContextProtocol.Tests/Protocol/CancelledNotificationParamsTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ public static void CancelledNotificationParams_SerializationRoundTrip_PreservesA
2323
Assert.Equal(original.RequestId, deserialized.RequestId);
2424
Assert.Equal(original.Reason, deserialized.Reason);
2525
Assert.NotNull(deserialized.Meta);
26+
Assert.Equal("value", (string)deserialized.Meta["key"]!);
2627
}
2728

2829
[Fact]

tests/ModelContextProtocol.Tests/Protocol/CompleteRequestParamsTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ public static void CompleteRequestParams_SerializationRoundTrip_PreservesAllProp
3232
Assert.NotNull(deserialized.Context.Arguments);
3333
Assert.Equal("en", deserialized.Context.Arguments["language"]);
3434
Assert.NotNull(deserialized.Meta);
35+
Assert.Equal("tok-1", (string)deserialized.Meta["progressToken"]!);
3536
}
3637

3738
[Fact]

tests/ModelContextProtocol.Tests/Protocol/CompleteResultTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ public static void CompleteResult_SerializationRoundTrip_PreservesAllProperties(
3232
Assert.Equal(10, deserialized.Completion.Total);
3333
Assert.True(deserialized.Completion.HasMore);
3434
Assert.NotNull(deserialized.Meta);
35+
Assert.Equal("value", (string)deserialized.Meta["key"]!);
3536
}
3637

3738
[Fact]

tests/ModelContextProtocol.Tests/Protocol/CreateMessageResultTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ public void CreateMessageResult_RoundTripWithAllFields()
164164
Assert.Equal(2, deserialized.Content.Count);
165165
Assert.Equal("toolUse", deserialized.StopReason);
166166
Assert.NotNull(deserialized.Meta);
167+
Assert.Equal("metadata", (string)deserialized.Meta["custom"]!);
167168
}
168169

169170
[Fact]

tests/ModelContextProtocol.Tests/Protocol/CreateTaskResultTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,5 +36,6 @@ public static void CreateTaskResult_SerializationRoundTrip_PreservesAllPropertie
3636
Assert.Equal(original.Task.TimeToLive, deserialized.Task.TimeToLive);
3737
Assert.Equal(original.Task.PollInterval, deserialized.Task.PollInterval);
3838
Assert.NotNull(deserialized.Meta);
39+
Assert.Equal("value", (string)deserialized.Meta["key"]!);
3940
}
4041
}

tests/ModelContextProtocol.Tests/Protocol/ElicitRequestParamsTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ public static void ElicitRequestParams_SerializationRoundTrip_PreservesAllProper
4040
Assert.NotNull(deserialized.Task);
4141
Assert.Equal(TimeSpan.FromMinutes(10), deserialized.Task.TimeToLive);
4242
Assert.NotNull(deserialized.Meta);
43+
Assert.Equal("tok-1", (string)deserialized.Meta["progressToken"]!);
4344
}
4445

4546
[Fact]

tests/ModelContextProtocol.Tests/Protocol/ElicitResultTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ public static void ElicitResult_SerializationRoundTrip_PreservesAllProperties()
3131
Assert.Equal("John", deserialized.Content["name"].GetString());
3232
Assert.Equal(30, deserialized.Content["age"].GetInt32());
3333
Assert.NotNull(deserialized.Meta);
34+
Assert.Equal("value", (string)deserialized.Meta["key"]!);
3435
}
3536

3637
[Fact]

tests/ModelContextProtocol.Tests/Protocol/ElicitationCompleteNotificationParamsTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ public static void ElicitationCompleteNotificationParams_SerializationRoundTrip_
2121
Assert.NotNull(deserialized);
2222
Assert.Equal("elicit-abc-123", deserialized.ElicitationId);
2323
Assert.NotNull(deserialized.Meta);
24+
Assert.Equal("value", (string)deserialized.Meta["key"]!);
2425
}
2526

2627
[Fact]

0 commit comments

Comments
 (0)