Skip to content

Conversation

@mark-wiemer
Copy link
Member

PR Checklist

Overview

When reviewing the PR that added these pages, I thought the + icons were from the diff tool, not present in the actual file! CC @TG199 as previous PR author to double-check changes like that :) nbd, my fault for being too lazy to build and preview the changes this time. I'll be more careful in the future

github-actions[bot]

This comment was marked as resolved.

@TG199
Copy link
Contributor

TG199 commented Sep 2, 2025

Thanks for catching that @mark-wiemer! You're absolutely right - those + symbols shouldn't be in the actual content. I must have accidentally included them when working with the diff view.
Appreciate you cleaning this up, and I'll be more careful to preview the built docs locally before submitting future PRs. Good lesson learned! 🙂
Question about completing #5248: Now that we have the related tools documentation migrated, should I also tackle moving the appropriate code examples to mocha-examples repo I'm thinking things like:

The EventEmitter spy examples from the original Spies wiki page
Test coverage integration examples mentioned on the wiki homepage
Framework integration examples (Express/Connect, etc.)

Would that be the next logical step, or do you prefer to handle the examples migration separately?

@mark-wiemer mark-wiemer merged commit 55fd22a into main Sep 7, 2025
94 of 95 checks passed
@mark-wiemer mark-wiemer deleted the fix-related-tools branch September 7, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants