Skip to content

Conversation

@boneskull
Copy link
Member

  • fiddle with caching
    • don't cache for smoke tests
    • npm@5 comes with node@8 or newer, so cache ~/.npm as well
    • otherwise, don't.
  • smoke test for each node.js version (stage 1)
  • lint (stage 2)
  • tests for each node.js version and browsers (stage 3)
  • addons (artifacts, sauce labs, chrome) are only present for browser tests!

YAML aliases are basically voodoo.

Signed-off-by: Christopher Hiller <[email protected]>
Signed-off-by: Christopher Hiller <[email protected]>
Signed-off-by: Christopher Hiller <[email protected]>
Signed-off-by: Christopher Hiller <[email protected]>
@boneskull boneskull added qa semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Apr 4, 2018
@boneskull boneskull requested a review from outsideris April 4, 2018 07:37
@boneskull boneskull force-pushed the experimental/travis branch from 21c01da to 1383060 Compare April 4, 2018 07:47
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.955% when pulling 1383060 on experimental/travis into f2560e7 on master.

@outsideris
Copy link
Contributor

It looks good!

There is one thing.

2018-04-05 00 39 25

It's hard to distinguish test.node and test.browser with node 9. Setting environment varibles can address this.
What do you think?

@boneskull
Copy link
Member Author

I raised this issue with Travis CI. If I set an environment variable then the cache can not be reused between the node and browser tests. There’s unfortunately no other way to distinguish them except to add a new stage at this point. Or just don’t worry about the caching

Copy link
Contributor

@outsideris outsideris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it. I hope that TravisCI addresses the problem.

sgilroy pushed a commit to TwineHealth/mocha that referenced this pull request Feb 27, 2019
* optimize build stages and jobs
* attempt to avoid $TARGET
* run smoke tests across multiple node versions
* define addons per-job
* disable caching for smoke tests; avoid alias
* disable caching for older node versions entirely
* combine bundle / browser tests; do not run extra node 9 job

Signed-off-by: Christopher Hiller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch implementation requires increase of "patch" version number; "bug fixes"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants