Fix error rethrow from cwd-relative path js config file #4702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@kirill-golovan thank you. |
Contributor
Author
Sure. |
juergba
added
type: bug
juergba
reviewed
Jul 25, 2021
juergba
approved these changes
Jul 25, 2021
Contributor
juergba
left a comment
juergba
left a comment
There was a problem hiding this comment.
@kirill-golovan thank you
juergba
added
the
run-browser-test
github-actions
bot
removed
the
run-browser-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixed incorrect comparison operator in
isModuleNotFoundErrorfunction inlib/cli/config.jsso Mocha rethrows error from cwd-relative path js config fileWhy should this be in core?
It is already in core but doesn't work as expected
Benefits
Mocha rethrows error from cwd-relative path js config file
Possible Drawbacks
None that I can think of
Applicable issues
Closes #4701
Is this a breaking change (major release)? No
Is it an enhancement (minor release)? No
Is it a bug fix, or does it not impact production code (patch release)? Yes