Upgrade docdash version - issue #3663 #3738
Conversation
|
|
|
@tendonstrength Please sign CLA. |
outsideris
left a comment
outsideris
left a comment
There was a problem hiding this comment.
LGTM and docs is fine. except CLA.
|
@outsideris I thought I had signed it and when I go to the CLA site it says I have signed. Weird that the check is not working:
Is there something I'm missing? |
|
@tendonstrength It's weird. The CLA bot may have some problem temporarily. |
|
@outsideris I'm going to try closing and re-opening the PR to see if it gives it a kick in the pants. |
|
I opened an issue against the CLA assistant project. Not sure if they can help but we'll see what they say: cla-assistant/cla-assistant#415 |
|
@outsideris I fixed the CLA issue. Turns out the commit had my work email address which didn't match my GitHub address. Please let me know if there's anything else, and thanks for taking a look at this. |
boneskull
left a comment
boneskull
left a comment
There was a problem hiding this comment.
LGTM, thanks!
@mochajs/core please don't merge until after v6.0.0 is out. @craigtaub is trying to get that release cut very soon.
boneskull
left a comment
boneskull
left a comment
There was a problem hiding this comment.
LGTM, thanks!
@mochajs/core please don't merge until after v6.0.0 is out. @craigtaub is trying to get that release cut very soon.
boneskull
added
area: documentation
|
I'll go ahead and resolve the conflicts and merge here. |
|
lgtm, thanks |
5 participants
Requirements
Description of the Change
Upgrading the docdash library to ^2.0.0 per issue #3663
Alternate Designs
N/A
Why should this be in core?
This is need to take advantage of functionality of newer docdash versions
Benefits
Newer features in new docdash versions
Possible Drawbacks
Possible dependency or document formatting issues. I spot checked generated docs and they seemed normal to me.
Applicable issues
Issue #3663