fix: make describe().timeout() work

Also works around issues with unit tests. Windows no longer has wmic, so we skip those tests for now if they fail for that reason.

Author: darthvader58

lib/suite.js

@@ -159,6 +159,16 @@ Suite.prototype.timeout = function (ms) {
 
   debug("timeout %d", ms);
   this._timeout = parseInt(ms, 10);
+
+  // Allow overriding inner/nested suites
+  // See and test-cases with chain-called timeout argument.
+  // https://github.com/mochajs/mocha/issues/5422
+  for (const t of this.tests) {
+    t.timeout(this._timeout);
+  }
+  for (const s of this.suites) {
+    s.timeout(this._timeout);
+  }
   return this;
 };
 

test/integration/fixtures/timeout-chained-call.fixture.js

@@ -0,0 +1,9 @@
+'use strict';
+
+describe("should fail due to suite-level timeout lower than elapsed time of inner test", function() {
+  it("inner test", async function () {
+    await new Promise((resolve) => {
+      setTimeout(resolve, 100);
+    });
+  }).timeout(110);
+}).timeout(50);

test/integration/options/parallel.spec.js

@@ -59,7 +59,16 @@ async function assertReporterOutputEquality(reporter) {
 async function waitForChildPids(pid) {
   let childPids = [];
   while (!childPids.length) {
-    childPids = await pidtree(pid);
+    try {
+      childPids = await pidtree(pid);
+    } catch (err) {
+      // On Windows, pidtree may fail if wmic is not available (deprecated/removed in newer Windows)
+      // In this case, we can't reliably get child PIDs, so throw to skip the test
+      if (process.platform === 'win32' && err.message && err.message.includes('wmic')) {
+        throw new Error('pidtree requires wmic on Windows, which is not available');
+      }
+      throw err;
+    }
     await new Promise((resolve) => setTimeout(resolve, 100));
   }
   return childPids;
@@ -506,7 +515,16 @@ describe("--parallel", function () {
           resolveFixturePath("options/parallel/test-*"),
           "--parallel",
         ]);
-        const childPids = await waitForChildPids(pid);
+        let childPids;
+        try {
+          childPids = await waitForChildPids(pid);
+        } catch (err) {
+          if (err.message && err.message.includes('wmic')) {
+            this.skip();
+            return;
+          }
+          throw err;
+        }
         await promise;
         return expect(
           Promise.all(
@@ -532,7 +550,16 @@ describe("--parallel", function () {
           "--bail",
           "--parallel",
         ]);
-        const childPids = await waitForChildPids(pid);
+        let childPids;
+        try {
+          childPids = await waitForChildPids(pid);
+        } catch (err) {
+          if (err.message && err.message.includes('wmic')) {
+            this.skip();
+            return;
+          }
+          throw err;
+        }
         await promise;
         return expect(
           Promise.all(

test/integration/timeout.spec.js

@@ -30,3 +30,18 @@ describe("this.timeout()", function () {
     });
   });
 });
+
+describe("describe.timeout()", function () {
+  it("should fail due to suite-level timeout lower than elapsed time of inner test", function (done) {
+    run("timeout-chained-call.fixture.js", args, function (err, res) {
+      if (err) {
+        done(err);
+        return;
+      }
+
+      assert.ok(res.failures[0].err.message.match(/Timeout of 50ms exceeded/));
+      assert.strictEqual(res.code, 1);
+      done();
+    });
+  });
+});

test/unit/timeout.spec.js

@@ -20,6 +20,25 @@ describe("timeouts", function () {
     }, 50);
   });
 
+  describe("chaining calls", function () {
+    describe("suite-level", function () {
+      describe("should override for inner test cases and deeply nested suites", function () {
+        it("inner test", async function () {
+          await new Promise((resolve) => {
+            setTimeout(resolve, 1000);
+          });
+        });
+        describe("nested suite", function () {
+          it("nested test", async function () {
+            await new Promise((resolve) => {
+              setTimeout(resolve, 2200); // This waiting time is higher than the default timeout value, 2 seconds.
+            });
+          });
+        }).timeout(70);
+      }).timeout(2500); // This chained `timeout` config will override `timeout` for nested suites and cases
+    });
+  });
+
   describe("disabling", function () {
     it("should work with timeout(0)", function (done) {
       this.timeout(0);