Skip to content

Commit e42327a

Browse files
authored
Merge pull request #44120 from thaJeztah/20.10_backport_update_tests
[20.10 backport] Update some tests for supplementary group permissions
2 parents bb0197c + fcd4df9 commit e42327a

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

integration-cli/docker_cli_run_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -775,7 +775,7 @@ func (s *DockerSuite) TestRunUserByIDZero(c *testing.T) {
775775
if err != nil {
776776
c.Fatal(err, out)
777777
}
778-
if !strings.Contains(out, "uid=0(root) gid=0(root) groups=10(wheel)") {
778+
if !strings.Contains(out, "uid=0(root) gid=0(root) groups=0(root),10(wheel)") {
779779
c.Fatalf("expected daemon user got %s", out)
780780
}
781781
}
@@ -1075,7 +1075,7 @@ func (s *DockerSuite) TestRunGroupAdd(c *testing.T) {
10751075
testRequires(c, DaemonIsLinux)
10761076
out, _ := dockerCmd(c, "run", "--group-add=audio", "--group-add=staff", "--group-add=777", "busybox", "sh", "-c", "id")
10771077

1078-
groupsList := "uid=0(root) gid=0(root) groups=10(wheel),29(audio),50(staff),777"
1078+
groupsList := "uid=0(root) gid=0(root) groups=0(root),10(wheel),29(audio),50(staff),777"
10791079
if actual := strings.Trim(out, "\r\n"); actual != groupsList {
10801080
c.Fatalf("expected output %s received %s", groupsList, actual)
10811081
}

integration-cli/docker_cli_swarm_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ func (s *DockerSwarmSuite) TestSwarmServiceWithGroup(c *testing.T) {
315315

316316
out, err = d.Cmd("exec", container, "id")
317317
assert.NilError(c, err, out)
318-
assert.Equal(c, strings.TrimSpace(out), "uid=0(root) gid=0(root) groups=10(wheel),29(audio),50(staff),777")
318+
assert.Equal(c, strings.TrimSpace(out), "uid=0(root) gid=0(root) groups=0(root),10(wheel),29(audio),50(staff),777")
319319
}
320320

321321
func (s *DockerSwarmSuite) TestSwarmContainerAutoStart(c *testing.T) {

0 commit comments

Comments
 (0)