Skip to content

Commit 509ed3f

Browse files
Michael Norrisfacebook-github-bot
authored andcommitted
Resolve "incorrect-portions-license" errors: add no license lint to top of GPU files with both licenses (facebookresearch#3965)
Summary: Pull Request resolved: facebookresearch#3965 This is the first diff in enabling linting. I wanted the diff which updates all files to be just the automated command and the .toml config files changes, so this diff is the preparation step. We need this because we get errors due to having both NVidia and FB license comment headers in the same files. See the errors in D64429711 under "linter-coverage-verification" signal. Context on linting: https://fb.workplace.com/groups/lintqa/posts/3762373340693743/?comment_id=3762915930639484&reply_comment_id=3763044163959994 Per OSS, we cannot remove the Nvidia notice: https://fb.workplace.com/groups/osssupport/posts/27179779734977284/?comment_id=27181801724775085&reply_comment_id=27181818148106776 Differential Revision: D64481766
1 parent 68f66bc commit 509ed3f

26 files changed

Lines changed: 28 additions & 3 deletions

CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# @lint-ignore-every LICENSELINT
12
# Copyright (c) Facebook, Inc. and its affiliates.
23
# All rights reserved.
34
#

cmake/FindMKL.cmake

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
# Copyright (c) Facebook, Inc. and its affiliates.
1+
# @lint-ignore-every LICENSELINT
2+
# Copyright (c) Meta, Inc. and its affiliates.
23
# All rights reserved.
34
#
45
# This source code is licensed under the BSD-style license found in the

cmake/link_to_faiss_lib.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright (c) Facebook, Inc. and its affiliates.
1+
# Copyright (c) Meta Platforms, Inc. and its affiliates.
22
# All rights reserved.
33
#
44
# This source code is licensed under the BSD-style license found in the

faiss/gpu/GpuDistance.cu

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*
@@ -64,7 +65,7 @@ bool should_use_raft(GpuDistanceParams args) {
6465

6566
if (device_major_version < 7)
6667
return false;
67-
68+
int x; // test this useless variable lint still works?
6869
return args.use_raft;
6970
}
7071

faiss/gpu/GpuIndex.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/GpuIndexCagra.cu

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/GpuIndexCagra.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/GpuResources.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/GpuResources.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

faiss/gpu/StandardGpuResources.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @lint-ignore-every LICENSELINT
12
/**
23
* Copyright (c) Facebook, Inc. and its affiliates.
34
*

0 commit comments

Comments
 (0)