Skip to content

chore(deps): update vitest monorepo to v4 (major) #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 1, 2025
Merged

chore(deps): update vitest monorepo to v4 (major) #47

merged 3 commits into from
Nov 1, 2025

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Oct 22, 2025 •
edited
Loading

This PR contains the following updates:

Package Change Age Confidence
@vitest/ui (source) ^3.2.4 -> ^4.0.0 age confidence
vitest (source) ^3.2.4 -> ^4.0.0 age confidence

Release Notes

vitest-dev/vitest (@​vitest/ui)

v4.0.6

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v4.0.5

Compare Source

   🐞 Bug Fixes
   🏎 Performance
    View changes on GitHub

v4.0.4

Compare Source

   🐞 Bug Fixes
   🏎 Performance
    View changes on GitHub

v4.0.3

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v4.0.2

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v4.0.1

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v4.0.0

Compare Source

   🚨 Breaking Changes
   🚀 Features
   🐞 Bug Fixes
   🏎 Performance
    View changes on GitHub

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@vercel
Copy link

vercel bot commented Oct 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
mimu-memo Ready Ready Preview Comment Nov 1, 2025 10:25am

@renovate renovate bot force-pushed the renovate/major-vitest-monorepo branch from 3b88cf5 to a1a1694 Compare October 23, 2025 21:34
@renovate renovate bot force-pushed the renovate/major-vitest-monorepo branch from a1a1694 to 79d683f Compare October 24, 2025 22:08
@renovate renovate bot force-pushed the renovate/major-vitest-monorepo branch from 79d683f to 53c6853 Compare October 27, 2025 16:04
@renovate renovate bot force-pushed the renovate/major-vitest-monorepo branch from 53c6853 to 96997a9 Compare October 29, 2025 18:47
@renovate renovate bot force-pushed the renovate/major-vitest-monorepo branch from 96997a9 to c11a532 Compare October 31, 2025 17:06
@renovate renovate bot force-pushed the renovate/major-vitest-monorepo branch from c11a532 to 59b9e8d Compare November 1, 2025 09:06
@claude
Copy link
Contributor

claude bot commented Nov 1, 2025 •
edited
Loading

Claude finished @renovate[bot]'s task —— View job

Vitest v4 Upgrade PR Review

Code Quality & Best Practices ✅

The upgrade from Vitest v3.2.4 to v4.0.0 is generally well-structured. The dependency updates in package.json and bun.lock look correct, and all 112 tests are passing successfully.

Critical Issue Found ❌

Breaking Change: Pool Configuration

File: vitest.config.ts:14-18

The poolOptions configuration is no longer valid in Vitest v4:

// ❌ This no longer works in v4
poolOptions: {
  threads: {
    singleThread: true,
  },
},

Error: Object literal may only specify known properties, and 'poolOptions' does not exist in type 'InlineConfig'.

Recommended Fix:

Replace the pool configuration with v4-compatible options:

// ✅ v4 compatible configuration
pool: 'threads',
fileParallelism: false,  // Replaces singleThread: true
maxWorkers: 1,          // Ensures single worker

Performance Considerations 🚀

  • Positive: The v4 upgrade includes significant performance improvements mentioned in release notes
  • Positive: New module-runner replaces vite-node for better performance
  • Note: Current single-thread config should be maintained for compatibility with existing test patterns

Security Assessment ✅

  • No security concerns identified in the dependency upgrade
  • All dependencies appear to be legitimate and from trusted sources
  • No malicious code detected in configuration files

Test Coverage Assessment ✅

  • Excellent: All 112 tests pass with the new version
  • Coverage: Tests span multiple areas:
    • Portfolio services (12 tests)
    • Memo services (21 tests)
    • UI components (13 tests)
    • Utilities and configurations (66 tests)
  • Setup: Test environment properly configured with jsdom and React Testing Library

Additional Recommendations

  1. Immediate Action Required: Fix the TypeScript compilation error by updating pool configuration
  2. Consider: Review if single-threaded execution is still necessary - v4 has improved parallel execution
  3. Optional: Explore new v4 features like:
    • expect.assert for type narrowing
    • Enhanced browser mode capabilities
    • New schema validation matchers

Summary

This is a solid upgrade with excellent test coverage, but requires one configuration fix to resolve the breaking change. Once the pool configuration is updated, this PR should be safe to merge.

Status: ❌ Needs configuration fix before merge
Risk Level: Low (only configuration change needed)
Test Coverage: ✅ Comprehensive (112 tests passing)

@renovate renovate bot force-pushed the renovate/major-vitest-monorepo branch from 59b9e8d to 080e633 Compare November 1, 2025 09:58
@claude
Copy link
Contributor

claude bot commented Nov 1, 2025

Code Review: Vitest v3 → v4 Upgrade

Overview

This PR upgrades Vitest from v3.2.4 to v4.0.6, which is a major version bump with significant breaking changes. While the dependency update itself is straightforward, there is a critical type-check failure that must be resolved before merging.

🚨 Critical Issues

1. Type Check Failure - poolOptions Configuration

Location: vitest.config.ts:14

Error:

error TS2769: No overload matches this call.
Object literal may only specify known properties, and 'poolOptions' does not exist in type 'InlineConfig'.

Root Cause:
Vitest v4.0 includes a major rewrite of the pool system (#8705) that removed tinypool as a dependency. This appears to have changed the configuration API.

Current Configuration (vitest.config.ts:14-18):

poolOptions: {
  threads: {
    singleThread: true,
  },
},

Required Action:
The poolOptions configuration needs to be updated to match Vitest v4's new API. Based on the breaking changes, this may involve:

  • Checking if poolOptions has been renamed or restructured
  • Verifying if singleThread option still exists or has been replaced
  • Consulting the v4 migration guide for the correct configuration syntax

Recommendation: Do not merge until this type error is resolved.

🔍 Breaking Changes Analysis

Based on the release notes, here are the key breaking changes that may affect this codebase:

1. Pool System Rewrite

  • Complete rewrite of pools without tinypool (#8705)
  • Impact: HIGH - Already causing type errors in the config
  • Action Required: Update vitest.config.ts pool configuration

2. TypeScript Types Location Changes

  • Removed Node types from main entry point; must use vitest/node instead (#8200)
  • Impact: MEDIUM - Check if any imports need updating
  • Current Config: tsconfig.json uses "types": ["vitest/globals"] - verify this still exists in v4

3. Module System Changes

  • Replaced vite-node with module-runner (#8208)
  • Impact: LOW - Should be transparent, but monitor for runtime issues

4. Spying Implementation Rewrite

  • Complete rewrite of spying to make module mocking more intuitive (#8363)
  • Impact: MEDIUM - Test existing mocks and spies after upgrade
  • Action: Review test files using vi.spyOn, vi.mock, or vi.mocked

5. Removed Deprecated APIs

  • Multiple deprecated options removed (#8428)
  • minWorkers removed and set automatically (#8454)
  • Impact: LOW - Current config doesn't use these

6. Snapshot Behavior Change

  • Obsolete snapshots now fail on CI (#7963)
  • Impact: MEDIUM - Monitor CI for snapshot-related failures

✅ Positive Changes

  1. Performance Improvements: Multiple optimizations in v4.0.4-v4.0.6
  2. Better Error Handling: Improved error messages and type safety
  3. Enhanced Browser Mode: Several improvements to browser testing capabilities
  4. Bug Fixes: 20+ bug fixes between v4.0.0 and v4.0.6

📋 Testing Recommendations

After fixing the type error, thoroughly test:

  1. All test suites pass: ✅ Currently passing (before type fix)
  2. Mocking and spying behavior: Review tests using vi.mock, vi.spyOn, vi.mocked
  3. Snapshot tests: Ensure no unexpected snapshot failures
  4. Test performance: Monitor for any performance regressions
  5. Development workflow: Verify bun run test, bun run test:ui work as expected

🔧 Recommended Actions

  1. Immediate (Blocking):

    • Fix poolOptions type error in vitest.config.ts
    • Verify vitest/globals types still exist in v4
    • Ensure all CI checks pass

  2. Before Merge:

    • Run full test suite locally after fixes
    • Test any files using vi.mock, vi.spyOn, or mocking functionality
    • Verify test UI works: bun run test:ui

  3. Post-Merge:

    • Monitor for any test flakiness or unexpected behavior
    • Review snapshot updates if any tests start failing
    • Check test execution performance

📚 Documentation

Summary

Status: ⛔ DO NOT MERGE - Type check failure must be resolved

This is a necessary upgrade to stay current with Vitest, but it requires addressing the breaking changes in the pool configuration. The good news is that tests are passing, suggesting the runtime behavior is mostly compatible. Once the type errors are fixed and verified, this should be safe to merge.

The upgrade brings performance improvements and bug fixes that will benefit the project long-term. However, careful attention must be paid to the mocking/spying rewrite, as this could introduce subtle behavioral changes.

@claude
Copy link
Contributor

claude bot commented Nov 1, 2025

PR Review: Vitest v3 → v4 Upgrade

Summary

This PR upgrades Vitest from v3.2.4 to v4.0.6, which includes several breaking changes. The configuration has been updated appropriately, but there is one critical issue preventing merge.

🚨 Critical Issue

Type Check Failure

  • Location: vitest.config.ts:6
  • Error: Unused '@ts-expect-error' directive
  • Root Cause: The @ts-expect-error comment on line 6 is no longer needed, likely because Vitest v4 has fixed the type compatibility issue with the Vite plugin that existed in v3

Required Fix:

- // @ts-expect-error Bun resolves two Vite type copies; suppress mismatched plugin signature.
  plugins: [react()],

Either remove the comment entirely or change it to a regular comment if documentation is needed.

✅ Positive Changes

  1. Correct Configuration Migration

    • poolOptions.threads.singleThread → fileParallelism: false ✓
    • Explicit maxWorkers: 1 setting ✓
    • These changes align with Vitest v4's breaking changes

  2. Dependency Updates

    • All vitest-related packages updated consistently to v4.0.6
    • Lock file properly updated

  3. Breaking Changes Handled

    • The PR correctly addresses the removal of deprecated poolOptions structure
    • Configuration now uses the new Vitest v4 API

📋 Recommendations

High Priority

  1. Fix the type-check error (blocking): Remove or update the @ts-expect-error directive at line 6

Medium Priority

  1. Test the upgrade thoroughly: Vitest v4 includes significant internal changes:

    • New module runner (replaces vite-node)
    • Rewritten spying implementation
    • New pool implementation (no longer uses tinypool)
    • Ensure all existing tests still pass correctly

  2. Review test behavior: The breaking changes in Vitest v4 include:

    • Different spy behavior - module mocking is now more intuitive but may behave differently
    • Obsolete snapshots now fail on CI by default
    • Default reporter changed from verbose to list format

Low Priority

  1. Consider adding release notes: Document any test behavior changes you observe after the upgrade
  2. Review chai upgrade: The chai dependency was upgraded from v5 → v6, which may have its own breaking changes

🔒 Security & Performance

  • ✅ No security concerns identified
  • ✅ Performance should improve (Vitest v4 includes performance optimizations)
  • ✅ No hardcoded secrets or sensitive data

📊 Test Coverage

  • All tests currently pass ✓
  • Lint check passes ✓
  • Type check fails ❌ (must fix before merge)

Conclusion

This is a well-structured dependency upgrade PR from Renovate. The configuration changes correctly address Vitest v4's breaking changes. However, the PR cannot be merged until the type-check failure is resolved.

Action Required: Remove the now-unnecessary @ts-expect-error directive from vitest.config.ts:6.

@mmrakt mmrakt merged commit dd68d0b into main Nov 1, 2025
6 checks passed
@mmrakt mmrakt deleted the renovate/major-vitest-monorepo branch November 1, 2025 10:25
@claude
Copy link
Contributor

claude bot commented Nov 1, 2025

Pull Request Review - Vitest 4.0 Upgrade

Overview

This PR upgrades Vitest from v3.2.4 to v4.0.6, a major version upgrade that includes significant breaking changes and improvements.

Summary

✅ LGTM - The changes look good. CI is passing and the migration appears to be properly handled.

Detailed Analysis

1. Code Quality & Best Practices ⭐

Positive Changes:

  • ✅ Removed TypeScript ignore comment (vitest.config.ts:6) - The @ts-ignore directive was removed, indicating better type safety with Vitest 4.0
  • ✅ Modernized pool configuration - Migration from poolOptions.threads.singleThread to fileParallelism: false + maxWorkers: 1 aligns with Vitest 4.0 API changes
  • ✅ Cleaner configuration - The new API is more explicit and easier to understand

Configuration Migration:

- poolOptions: {
-   threads: {
-     singleThread: true,
-   },
- },
+ fileParallelism: false,
+ maxWorkers: 1,

This change follows Vitest 4.0's breaking change where the pool architecture was rewritten without tinypool.

2. Potential Issues & Concerns 🔍

Breaking Changes to Be Aware Of:

Based on the release notes, here are key breaking changes that may affect your tests:

  1. Spy Implementation Rewrite - Module mocking behavior changed significantly. Review any tests using vi.mock() or vi.spyOn()
  2. Chai v6 Upgrade - The internal assertion library was upgraded from chai v5 to v6, which may have subtle API differences
  3. No longer using vite-node - Now uses module-runner, which could affect module resolution in edge cases
  4. Snapshot behavior - Obsolete snapshots now fail on CI by default (good for test hygiene)
  5. Reporter changes - verbose reporter now prints in list format; new tree reporter available for tree view

Recommendations:

  • ✅ Run the full test suite locally after merge: bun run test
  • ✅ Check for any deprecation warnings in test output
  • ⚠️ Pay special attention to tests that use mocking/spying functionality
  • ⚠️ Review any custom reporters or coverage configurations

3. Performance Considerations 🚀

Improvements:

  • ✅ New pool implementation without tinypool dependency should be faster
  • ✅ Better memory management with rewritten spy system
  • ✅ Optimized expect assertions (per release notes)

Current Configuration:
Your test configuration uses fileParallelism: false and maxWorkers: 1, which means:

  • Tests run sequentially in a single worker
  • Good for: Tests with shared state or side effects
  • Trade-off: Slower execution vs parallel mode

4. Security Considerations 🔒

Dependency Updates:

  • ✅ No security vulnerabilities noted in the upgrade
  • ✅ All dependencies are from trusted sources (Vitest is a well-maintained project)
  • ✅ Lockfile (bun.lock) properly updated with new dependency graph

Notable Dependency Changes:

  • chai: 5.2.1 → 6.2.0
  • debug: 4.4.1 → 4.4.3
  • magic-string: 0.30.17 → 0.30.21
  • tinyrainbow: 2.0.0 → 3.0.3
  • Removed: assertion-error, check-error, deep-eql, pathval, loupe, tinypool, tinyspy, cac, strip-literal
  • Added: @standard-schema/[email protected]

5. Test Coverage 📊

Test Files Found (13 total):

  • ✅ Career module: 3 test files
  • ✅ Config: 1 test file
  • ✅ Memo module: 5 test files
  • ✅ Portfolio module: 3 test files
  • ✅ Service layer: 1 test file

CI Status:

  • ✅ All checks passing (lint, test, type-check)
  • ✅ No test failures reported

Recommendations

Immediate Actions

  1. ✅ Merge when ready - CI is green, changes look good
  2. ⚠️ Monitor first deployment - Watch for any runtime issues with the new spy implementation
  3. ✅ Update team - Inform developers about the major version change

Follow-up Tasks (Optional)

  1. Consider enabling tree reporter for better test output visualization:

    test: {
  reporters: ['tree'], // or 'verbose' for list view
}

  2. Review and potentially update test patterns for the new spy implementation if you notice any behavioral changes

  3. Take advantage of new Vitest 4.0 features:

    • expect.assert for type narrowing
    • Schema validation matchers
    • Better TypeScript inference

Compliance with CLAUDE.md Guidelines ✅

  • ✅ Uses bun package manager
  • ✅ TypeScript strict mode compatibility maintained
  • ✅ No console statements or debug code added
  • ✅ Configuration follows project conventions
  • ✅ Breaking changes handled appropriately

Conclusion

This is a well-executed dependency update. The configuration migration is correct, CI is passing, and the codebase appears ready for Vitest 4.0. The breaking changes are mostly internal to Vitest and shouldn't affect your existing tests, but it's worth running the test suite locally and watching the first deployment.

Recommendation: ✅ APPROVE & MERGE

Good work by Renovate Bot on keeping dependencies up to date! 🎉

@qodo-merge-for-open-source
Copy link

qodo-merge-for-open-source bot commented Nov 1, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
⚪
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

⚪
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status:
No audit scope: The changes only adjust Vitest configuration and dependencies without introducing or
affecting application audit logging of critical actions, so compliance cannot be
determined from the diff.

Referred Code 
export default defineConfig({
  plugins: [react()],
  test: {
    environment: 'jsdom',
    globals: true,
    setupFiles: './vitest.setup.ts',
    includeSource: ['app/**/*.{js,ts,jsx,tsx}'],
    pool: 'threads',
    fileParallelism: false,
    maxWorkers: 1,
  },
Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status:
No error paths: The diff only updates test runner configuration and dependencies and does not include
executable logic where error handling or edge cases would apply, so compliance cannot be
assessed.

Referred Code 
export default defineConfig({
  plugins: [react()],
  test: {
    environment: 'jsdom',
    globals: true,
    setupFiles: './vitest.setup.ts',
    includeSource: ['app/**/*.{js,ts,jsx,tsx}'],
    pool: 'threads',
    fileParallelism: false,
    maxWorkers: 1,
  },
Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status:
No user errors: No user-facing error messages are introduced or modified in this diff, as it only changes
testing configuration, so secure error handling cannot be evaluated.

Referred Code 
export default defineConfig({
  plugins: [react()],
  test: {
    environment: 'jsdom',
    globals: true,
    setupFiles: './vitest.setup.ts',
    includeSource: ['app/**/*.{js,ts,jsx,tsx}'],
    pool: 'threads',
    fileParallelism: false,
    maxWorkers: 1,
  },
Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status:
Dependency update: This PR updates testing-related dependencies and toggles Vitest execution settings without
touching input handling code, so validation and data handling security cannot be
determined from the diff.

Referred Code 
  "@vitest/ui": "^4.0.0",
  "chokidar": "^4.0.3",
  "jsdom": "^27.0.0",
  "jsonc-parser": "^3.3.1",
  "lefthook": "^1.13.1",
  "postcss": "^8.5.6",
  "remark": "^15.0.1",
  "rss-parser": "^3.13.0",
  "strip-markdown": "^6.0.0",
  "tailwindcss": "^4",
  "tsx": "^4.20.3",
  "typescript": "^5",
  "ultracite": "6.1.0",
  "vitest": "^4.0.0"
},
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Review effort 2/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmrakt