Super softtakeover#279
Merged
Merged
Conversation
…art allways with its default values.
Member
Author
|
IMHO this should be part of 1.12. Who can have a look at it? |
Member
There was a problem hiding this comment.
is it safe to do this sort of translation inline? Maybe it'd be better to call a param-to-midi function
Member
Author
There was a problem hiding this comment.
It bypasses the center hack. But this does not matter here because the threshold is bigger than the error anyway.
Do you think it is worth to "fix" it?
Member
There was a problem hiding this comment.
maybe not, I just worry because we've had a lot of midi conversion bugs
Member
|
if you address the other notes I made I will probably lgtm this :) |
Introduced midiValueToParameter and make use of it. Removed some redundant code.
Member
Author
|
Addressed and tested on my setup. |
Conflicts: src/effects/effectparameterslot.cpp src/effects/effectparameterslot.h src/effects/effectslot.cpp src/effects/effectslot.h
Member
Author
|
I will merge this now, because it is really annoying to test the effects without it. |
This was referenced Aug 22, 2022
m0dB
pushed a commit
to m0dB/mixxx
that referenced
this pull request
Jan 21, 2024
* pelicanconf: add davidchocholaty gsoc 2022 student The commit adds David Chocholaty to the developers as a participant for the GSoC 2022. With that, the avatar for the developer is added to content/images/avatars. * content/news: add GSoC 2022 Work Product This commit adds the final blog with the work product for the Google Summer of Code 2022. The blog is written for the Pitch Shift effect and Group delay handling project which was implemented by davidchocholaty contributor. * content/news: fix table borders This commit fixes the borders of the benchmarking results tables. * content/news: extend Things I learned from GSoC This commit extends the chapter "Things I learned from the GSoC" with a description of what I learned due to the change of goal in the project extension. * content/news: fix sentence meaning The commit fixes the meaning of a sentence in the Acknowledgements chapter. * content/news: fix grammar for words separately This commit fixes the grammar for words, and some of them, are replaced with better synonyms. * content/news: add text and images for Conclusion The commit adds text and images for the Conclusion chapter. This chapter summarizes the work done and the contributor's activity during the GSoC period. * content/news: remove HTML tags The commit replaces the HTML tags for lists with the markdown approach with the star symbol. With that, every "-" symbol for easy lists is replaced with a star "*" symbol as well. With that, the <hr /> tag is replaced with "---". * content/news: modify the Motivation chapter The commit modify the description of the deck's slider and why the new Pitch shift effect should have been implemented. * content/news: re-phrase definitions The commit re-phrases the definitions in the Background chapter. Specifically, the Semitone and Audio buffer descriptions were re-phrased. * content/news: remake minimum requirements policy The commit removes the Minimum requirements policy from the background chapter and the link for Mixxx's description is added to the term mentioned in the document body. * content/news: add repository name This commit adds the repository name before the pull request hash to identify for which repository was the pull request created. * content/news: put the class names into backquotes The commit puts the class names into backquotes so they will appear in monospace. * content/news: more specify own policy for Mixxx The commit specifies more with the word "own", that the Minimum requirements policy is just own Mixxx's policy for the Ubuntu LTS. * content/news: fix list indentation The commit fixes the indentation of the list for the Background chapter. Now, the rendered HTML should be correctly indented as well. * content/news: add disclaimer The commit adds a disclaimer that the blog post primarily serves as documentation for the Google Summer of Code project. * content/news: replace an interval term description The commit replaces the previous messy description of the term Interval with a better one. * content/news: add a reference to the source This commit adds the link for the source of the Interval description. * content/news: replace latency definition The commit replaces the definition of Latency with the new more detailed and in audio approach way. The dependent links are added to the resources and the old one is removed. * content/news: fix links length The commit fixes links length in Markdown a little bit by entering the link to the new line. * content/news: replace with permalink The commit replaces the links to files on GitHub with permalinks instead. * content/news: add missing repository name The commit adds a missing repository name for the link on the pull request in the plain text part. * content/news: add space indent for links The commit adds a one-space indent for the links that are written on two rows. * content/news: add blog post PR The commit adds the PR containing the blog post with the "Work Product" for Google Summer of Code 2022 to the list of PRs. * content/news: replace graph images with svg's The commit replaces graphs with the transparent version in svg format. The graphs also have the y-axis starting from zero. * content/news: add authors page This commit adds the author's page for the Mixxx developers Daniel Schürmann and Nikolaus Einhauser. * content/news: add tags The commit adds tags for the blog post. Concretely the gsoc and gsoc-2022 tags were added. * content/news: add Fatih Emre author page The commit adds a GitHub page for the Fatih Emre GSoC 2022 participant and Mixxx developer. * content/news: move citations into annotations This commit moves the citation resources from the Resources chapter into the annotations. * content/news: mark std::span as code The commit wraps the std::span into backquotes, so it will highlight on the rendered page as code. * content/news: fix grammar and structure of text The commit fixes the grammar of English text and the structure of a plain text. * content/news: add alternative text for images The commit finished TODO by adding alternative text for images. * content/news: hide the Demo video chapter This commit hides the Demo video chapter until the correct video will be uploaded on the Mixxx YouTube channel. * content/news: remove wrong footnote usage The commit removes a forgotten citation, which should be removed. * content/news: add a link to the demo video The commit adds a link to an uploaded video of the Pitch shift effect demo on the Mixxx YouTube channel. * content/news: deduplicate the CPU info The commit deduplicates the info about the CPU caches for benchmarking output results. For the second result, it is mentioned, that the system is the same as previously. * content/news: add PR status The commit adds PR status on GitHub and for WIP PRs, the last commit that was added in GSoC Coding Period is mentioned and linked. * content/news: add what is left to do for mixxxdj#10840 This commit adds information about when the PR will be able to merge. * content/news: add a repository to insights names The commit adds primarily the repository into the description of the contributor summary insights image. * content/news: add Be. into acknowledgements This commit adds Be. into acknowledgements with thanks for taking care of publishing the demo video. * content/news: improve text with meaning fixes The commit improves text with some meaning fixes for the Introduction and Motivation chapters. * content/news: improve list items order The commit improves the order of the items on the list in the Background chapter. * content/news: std::span into backquotes The commit adds a second mention of the std::span into backquotes for code-style generation on the page. * content/news: improve the Pull requests and issues This commit improves the Pull requests and issues chapter with some grammar fixes or updates and adds a definition of the Sample Rate term into the Background chapter. * content/news: improve the Implementation chapter The commit improves the Implementation chapter. With that, some letter sizes are adjusted. * content/news: improve the rest of the chapters The commit improves chapters starting the Testing and benchmarking chapter to the end of the blog post. With that, the links for the GSoC and SoundTouch library are added. * content/news: fix Be. author link The commit fixes the link for the author. * content/news: fix the modified article The commit fixes the almost modified articles 'a' and 'the' back. * content/news: remove load average info The commit removes the information about the load average of the system from the benchmark results. * content/news: grammar and structure fixes for blog The commit fixes some grammar and improves a little bit structure of the blog post. * content/news: move Pull requests and issues This commit moves the Pull requests and issues chapter after the Challenges chapter (before Future Work). * content/news: rename GSoC's final blog post This commit renames the GSoC final blog post with the XXXX-XX-XX date pattern. * content/news: use developer word instead The commit changes the Mixxx organization administrator designation to the Mixxx organization developer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces soft takeover for the super knob effect parameter connection.
The super knob jumps to the current value of the linked parameter on effect load.
https://bugs.launchpad.net/mixxx/+bug/1329063
https://bugs.launchpad.net/mixxx/+bug/1335355
It also includes some soft takeover refactoring