From 9c957a958014cd46ade86fb93dbee9a5507a8036 Mon Sep 17 00:00:00 2001 From: prakashsvmx Date: Wed, 3 Sep 2025 16:15:18 +0530 Subject: [PATCH 1/5] try node v24 in ci --- .github/workflows/test.yml | 2 +- src/internal/type.ts | 55 +++++++++++++++++++------------------- 2 files changed, 28 insertions(+), 29 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 1e30679e..6dc6b577 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -15,7 +15,7 @@ jobs: strategy: max-parallel: 5 matrix: - node_version: [22.x, 20.x, 18.x, 16.x ] + node_version: [24.x, 22.x, 20.x, 18.x, 16.x ] os: [ ubuntu-latest, windows-latest ] env: diff --git a/src/internal/type.ts b/src/internal/type.ts index 22abc4a4..6d90eee2 100644 --- a/src/internal/type.ts +++ b/src/internal/type.ts @@ -22,43 +22,42 @@ export type ResponseHeader = Record export type ObjectMetaData = Record export type RequestHeaders = Record +export type EnabledOrDisabledStatus = 'Enabled' | 'Disabled' + +export const ENCRYPTION_TYPES = { + SSEC: 'SSE-C', + KMS: 'KMS', +} as const + +export type ENCRYPTION_TYPES = (typeof ENCRYPTION_TYPES)[keyof typeof ENCRYPTION_TYPES] export type Encryption = | { - type: ENCRYPTION_TYPES.SSEC + type: typeof ENCRYPTION_TYPES.SSEC } | { - type: ENCRYPTION_TYPES.KMS + type: typeof ENCRYPTION_TYPES.KMS SSEAlgorithm?: string KMSMasterKeyID?: string } -export type EnabledOrDisabledStatus = 'Enabled' | 'Disabled' -export enum ENCRYPTION_TYPES { - /** - * SSEC represents server-side-encryption with customer provided keys - */ - SSEC = 'SSE-C', - /** - * KMS represents server-side-encryption with managed keys - */ - KMS = 'KMS', -} - -export enum RETENTION_MODES { - GOVERNANCE = 'GOVERNANCE', - COMPLIANCE = 'COMPLIANCE', -} - -export enum RETENTION_VALIDITY_UNITS { - DAYS = 'Days', - YEARS = 'Years', -} - -export enum LEGAL_HOLD_STATUS { - ENABLED = 'ON', - DISABLED = 'OFF', -} +export const RETENTION_MODES = { + GOVERNANCE: 'GOVERNANCE', + COMPLIANCE: 'COMPLIANCE', +} as const +export type RETENTION_MODES = (typeof RETENTION_MODES)[keyof typeof RETENTION_MODES] + +export const RETENTION_VALIDITY_UNITS = { + DAYS: 'Days', + YEARS: 'Years', +} as const +export type RETENTION_VALIDITY_UNITS = (typeof RETENTION_VALIDITY_UNITS)[keyof typeof RETENTION_VALIDITY_UNITS] + +export const LEGAL_HOLD_STATUS = { + ENABLED: 'ON', + DISABLED: 'OFF', +} as const +export type LEGAL_HOLD_STATUS = (typeof LEGAL_HOLD_STATUS)[keyof typeof LEGAL_HOLD_STATUS] export type Transport = Pick From 9f234dcde51d53066fea60b020b0627c370e1111 Mon Sep 17 00:00:00 2001 From: prakashsvmx Date: Wed, 3 Sep 2025 16:19:50 +0530 Subject: [PATCH 2/5] try node v24 in ci --- .github/workflows/test.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 6dc6b577..f647848c 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -51,6 +51,9 @@ jobs: - run: npm i + - name: Build TypeScript + run: npm run build + - name: Run Unit and Functional Tests timeout-minutes: 10 env: From 33c3be7abd9fd95b5338470804f20516f8c71598 Mon Sep 17 00:00:00 2001 From: prakashsvmx Date: Wed, 3 Sep 2025 17:05:21 +0530 Subject: [PATCH 3/5] try node v24 in ci --- .github/workflows/test.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f647848c..c5b0fd48 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -15,7 +15,7 @@ jobs: strategy: max-parallel: 5 matrix: - node_version: [24.x, 22.x, 20.x, 18.x, 16.x ] + node_version: [ 22.x ] os: [ ubuntu-latest, windows-latest ] env: @@ -51,9 +51,6 @@ jobs: - run: npm i - - name: Build TypeScript - run: npm run build - - name: Run Unit and Functional Tests timeout-minutes: 10 env: From 86f8352339bfca0267f54c8e3e425baee4bbf39d Mon Sep 17 00:00:00 2001 From: prakashsvmx Date: Wed, 3 Sep 2025 17:36:57 +0530 Subject: [PATCH 4/5] try node v24 in ci --- src/internal/extensions.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/internal/extensions.ts b/src/internal/extensions.ts index 776ea3de..b2484d16 100644 --- a/src/internal/extensions.ts +++ b/src/internal/extensions.ts @@ -24,7 +24,11 @@ import type { BucketItemWithMetadata, BucketStream } from './type.ts' import { parseListObjectsV2WithMetadata } from './xml-parser.ts' export class Extensions { - constructor(private readonly client: TypedClient) {} + private readonly client: TypedClient + + constructor(client: TypedClient) { + this.client = client + } /** * List the objects in the bucket using S3 ListObjects V2 With Metadata From de4a94db3d503c2815eb9fc8e8121d56d59e6682 Mon Sep 17 00:00:00 2001 From: prakashsvmx Date: Wed, 3 Sep 2025 17:39:20 +0530 Subject: [PATCH 5/5] try node v24 in ci --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index c5b0fd48..6dc6b577 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -15,7 +15,7 @@ jobs: strategy: max-parallel: 5 matrix: - node_version: [ 22.x ] + node_version: [24.x, 22.x, 20.x, 18.x, 16.x ] os: [ ubuntu-latest, windows-latest ] env: