Skip to content

Commit 21e21a3

Browse files
authored
Add AMTRELAY and IPSECKEY RR types (#1402)
* bump deps for go generate * add AMTRELAY and IPSECKEY RRs * PR fixes * PR fixes * AMTRELAY: remove special-casing for discovery
1 parent a36d0ce commit 21e21a3

13 files changed

Lines changed: 532 additions & 26 deletions

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ Example programs can be found in the `github.com/miekg/exdns` repository.
144144
* 340{1,2,3} - NAPTR record
145145
* 3445 - Limiting the scope of (DNS)KEY
146146
* 3597 - Unknown RRs
147+
* 4025 - A Method for Storing IPsec Keying Material in DNS
147148
* 403{3,4,5} - DNSSEC + validation functions
148149
* 4255 - SSHFP record
149150
* 4343 - Case insensitivity
@@ -179,6 +180,7 @@ Example programs can be found in the `github.com/miekg/exdns` repository.
179180
* 8080 - EdDSA for DNSSEC
180181
* 8499 - DNS Terminology
181182
* 8659 - DNS Certification Authority Authorization (CAA) Resource Record
183+
* 8777 - DNS Reverse IP Automatic Multicast Tunneling (AMT) Discovery
182184
* 8914 - Extended DNS Errors
183185
* 8976 - Message Digest for DNS Zones (ZONEMD RR)
184186

duplicate_generate.go

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

go.mod

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ module github.com/miekg/dns
33
go 1.14
44

55
require (
6-
golang.org/x/net v0.0.0-20210726213435-c6fcb2dbf985
7-
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c
8-
golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c
9-
golang.org/x/tools v0.1.6-0.20210726203631-07bc1bf47fb2
6+
golang.org/x/net v0.2.0
7+
golang.org/x/sync v0.1.0
8+
golang.org/x/sys v0.2.0
9+
golang.org/x/tools v0.3.0
1010
)

go.sum

Lines changed: 24 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,35 @@
1-
github.com/yuin/goldmark v1.3.5/go.mod h1:mwnBkeHKe2W/ZEtQ+71ViKU8L12m81fl3OWwC1Zlc8k=
1+
github.com/yuin/goldmark v1.4.13/go.mod h1:6yULJ656Px+3vBD8DxQVa3kxgyrAnzto9xy5taEt/CY=
22
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
3-
golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
4-
golang.org/x/mod v0.4.2 h1:Gz96sIWK3OalVv/I/qNygP42zyoKp3xptRVCWRFEBvo=
5-
golang.org/x/mod v0.4.2/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
6-
golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
3+
golang.org/x/crypto v0.0.0-20210921155107-089bfa567519/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc=
4+
golang.org/x/mod v0.6.0-dev.0.20220419223038-86c51ed26bb4/go.mod h1:jJ57K6gSWd91VN4djpZkiMVwK6gcyfeH4XE8wZrZaV4=
5+
golang.org/x/mod v0.7.0 h1:LapD9S96VoQRhi/GrNTqeBJFrUjs5UHCAtTlgwA5oZA=
6+
golang.org/x/mod v0.7.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs=
77
golang.org/x/net v0.0.0-20190620200207-3b0461eec859/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s=
8-
golang.org/x/net v0.0.0-20210405180319-a5a99cb37ef4/go.mod h1:p54w0d4576C0XHj96bSt6lcn1PtDYWL6XObtHCRCNQM=
9-
golang.org/x/net v0.0.0-20210726213435-c6fcb2dbf985 h1:4CSI6oo7cOjJKajidEljs9h+uP0rRZBPPPhcCbj5mw8=
10-
golang.org/x/net v0.0.0-20210726213435-c6fcb2dbf985/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y=
8+
golang.org/x/net v0.0.0-20210226172049-e18ecbb05110/go.mod h1:m0MpNAwzfU5UDzcl9v0D8zg8gWTRqZa9RBIspLL5mdg=
9+
golang.org/x/net v0.0.0-20220722155237-a158d28d115b/go.mod h1:XRhObCWvk6IyKnWLug+ECip1KBveYUHfp+8e9klMJ9c=
10+
golang.org/x/net v0.2.0 h1:sZfSu1wtKLGlWI4ZZayP0ck9Y73K1ynO6gqzTdBVdPU=
11+
golang.org/x/net v0.2.0/go.mod h1:KqCZLdyyvdV855qA2rE3GC2aiw5xGR5TEjj8smXukLY=
1112
golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
12-
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c h1:5KslGYwFpkhGh+Q16bwMP3cOontH8FOep7tGV86Y7SQ=
13-
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
13+
golang.org/x/sync v0.0.0-20220722155255-886fb9371eb4/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
14+
golang.org/x/sync v0.1.0 h1:wsuoTGHzEhffawBOhz5CYhcrV4IdKZbEyZjBMuTp12o=
15+
golang.org/x/sync v0.1.0/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
1416
golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
15-
golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
1617
golang.org/x/sys v0.0.0-20201119102817-f84b799fce68/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
17-
golang.org/x/sys v0.0.0-20210330210617-4fbd30eecc44/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
18-
golang.org/x/sys v0.0.0-20210423082822-04245dca01da/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
19-
golang.org/x/sys v0.0.0-20210510120138-977fb7262007/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
20-
golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c h1:F1jZWGFhYfh0Ci55sIpILtKKK8p3i2/krTr0H1rg74I=
21-
golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
18+
golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
19+
golang.org/x/sys v0.0.0-20220520151302-bc2c85ada10a/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
20+
golang.org/x/sys v0.0.0-20220722155257-8c9f86f7a55f/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
21+
golang.org/x/sys v0.2.0 h1:ljd4t30dBnAvMZaQCevtY0xLLD0A+bRZXbgLMLU1F/A=
22+
golang.org/x/sys v0.2.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
2223
golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
24+
golang.org/x/term v0.0.0-20210927222741-03fcf44c2211/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8=
25+
golang.org/x/term v0.2.0/go.mod h1:TVmDHMZPmdnySmBfhjOoOdhjzdE1h4u1VwSiw2l1Nuc=
2326
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
2427
golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
25-
golang.org/x/text v0.3.6/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
28+
golang.org/x/text v0.3.7/go.mod h1:u+2+/6zg+i71rQMx5EYifcz6MCKuco9NR6JIITiCfzQ=
29+
golang.org/x/text v0.4.0/go.mod h1:mrYo+phRRbMaCq/xk9113O4dZlRixOauAjOtrjsXDZ8=
2630
golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
2731
golang.org/x/tools v0.0.0-20191119224855-298f0cb1881e/go.mod h1:b+2E5dAYhXwXZwtnZ6UAqBI28+e2cm9otk0dWdXHAEo=
28-
golang.org/x/tools v0.1.6-0.20210726203631-07bc1bf47fb2 h1:BonxutuHCTL0rBDnZlKjpGIQFTjyUVTexFOdWkB6Fg0=
29-
golang.org/x/tools v0.1.6-0.20210726203631-07bc1bf47fb2/go.mod h1:o0xws9oXOQQZyjljx8fwUC0k7L1pTE6eaCbjGeHmOkk=
32+
golang.org/x/tools v0.1.12/go.mod h1:hNGJHUnrk76NpqgfD5Aqm5Crs+Hm0VOH/i9J2+nxYbc=
33+
golang.org/x/tools v0.3.0 h1:SrNbZl6ECOS1qFzgTdQfWXZM9XBkiA6tkFrH9YSTPHM=
34+
golang.org/x/tools v0.3.0/go.mod h1:/rWhSS2+zyEVwoJf8YAX6L2f0ntZ7Kn/mGgAWcipA5k=
3035
golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
31-
golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
32-
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE=
33-
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=

msg_generate.go

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

msg_helpers.go

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -810,3 +810,37 @@ func unpackDataAplPrefix(msg []byte, off int) (APLPrefix, int, error) {
810810
Network: ipnet,
811811
}, off, nil
812812
}
813+
814+
func unpackIPSECGateway(msg []byte, off int, gatewayType uint8) (net.IP, string, int, error) {
815+
var retAddr net.IP
816+
var retString string
817+
var err error
818+
819+
switch gatewayType {
820+
case IPSECGatewayNone: // do nothing
821+
case IPSECGatewayIPv4:
822+
retAddr, off, err = unpackDataA(msg, off)
823+
case IPSECGatewayIPv6:
824+
retAddr, off, err = unpackDataAAAA(msg, off)
825+
case IPSECGatewayHost:
826+
retString, off, err = UnpackDomainName(msg, off)
827+
}
828+
829+
return retAddr, retString, off, err
830+
}
831+
832+
func packIPSECGateway(gatewayAddr net.IP, gatewayString string, msg []byte, off int, gatewayType uint8, compression compressionMap, compress bool) (int, error) {
833+
var err error
834+
835+
switch gatewayType {
836+
case IPSECGatewayNone: // do nothing
837+
case IPSECGatewayIPv4:
838+
off, err = packDataA(gatewayAddr, msg, off)
839+
case IPSECGatewayIPv6:
840+
off, err = packDataAAAA(gatewayAddr, msg, off)
841+
case IPSECGatewayHost:
842+
off, err = packDomainName(gatewayString, msg, off, compression, compress)
843+
}
844+
845+
return off, err
846+
}

parse_test.go

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2015,3 +2015,30 @@ func TestParseZONEMD(t *testing.T) {
20152015
}
20162016
}
20172017
}
2018+
2019+
func TestParseIPSECKEY(t *testing.T) {
2020+
dt := map[string]string{
2021+
"ipseckey. 3600 IN IPSECKEY 10 0 2 . AQNRU3mG7TVTO2BkR47usntb102uFJtugbo6BSGvgqt4AQ==": "ipseckey.\t3600\tIN\tIPSECKEY\t10 0 2 . AQNRU3mG7TVTO2BkR47usntb102uFJtugbo6BSGvgqt4AQ==",
2022+
}
2023+
2024+
for i, o := range dt {
2025+
rr := testRR(i).(*IPSECKEY)
2026+
if s := rr.String(); s != o {
2027+
t.Errorf("input %#v does not match expected output %#v", s, o)
2028+
}
2029+
}
2030+
}
2031+
2032+
func TestParseAMTRELAY(t *testing.T) {
2033+
dt := map[string]string{
2034+
"amtrelay. 3600 IN AMTRELAY 10 0 2 2001:470:30:84:e276:63ff:fe72:3900": "amtrelay.\t3600\tIN\tAMTRELAY\t10 0 2 2001:470:30:84:e276:63ff:fe72:3900",
2035+
"amtrelay. 3600 IN AMTRELAY 10 1 2 2001:470:30:84:e276:63ff:fe72:3900": "amtrelay.\t3600\tIN\tAMTRELAY\t10 1 2 2001:470:30:84:e276:63ff:fe72:3900",
2036+
}
2037+
2038+
for i, o := range dt {
2039+
rr := testRR(i).(*AMTRELAY)
2040+
if s := rr.String(); s != o {
2041+
t.Errorf("input %#v does not match expected output %#v", s, o)
2042+
}
2043+
}
2044+
}

scan_rr.go

Lines changed: 112 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package dns
33
import (
44
"bytes"
55
"encoding/base64"
6+
"errors"
67
"net"
78
"strconv"
89
"strings"
@@ -1216,6 +1217,117 @@ func (rr *DS) parse(c *zlexer, o string) *ParseError { return rr.parseDS(c,
12161217
func (rr *DLV) parse(c *zlexer, o string) *ParseError { return rr.parseDS(c, o, "DLV") }
12171218
func (rr *CDS) parse(c *zlexer, o string) *ParseError { return rr.parseDS(c, o, "CDS") }
12181219

1220+
func (rr *IPSECKEY) parse(c *zlexer, o string) *ParseError {
1221+
l, _ := c.Next()
1222+
num, err := strconv.ParseUint(l.token, 10, 8)
1223+
if err != nil || l.err {
1224+
return &ParseError{"", "bad IPSECKEY value", l}
1225+
}
1226+
rr.Precedence = uint8(num)
1227+
c.Next() // zBlank
1228+
1229+
l, _ = c.Next()
1230+
num, err = strconv.ParseUint(l.token, 10, 8)
1231+
if err != nil || l.err {
1232+
return &ParseError{"", "bad IPSECKEY value", l}
1233+
}
1234+
rr.GatewayType = uint8(num)
1235+
c.Next() // zBlank
1236+
1237+
l, _ = c.Next()
1238+
num, err = strconv.ParseUint(l.token, 10, 8)
1239+
if err != nil || l.err {
1240+
return &ParseError{"", "bad IPSECKEY value", l}
1241+
}
1242+
rr.Algorithm = uint8(num)
1243+
c.Next() // zBlank
1244+
1245+
l, _ = c.Next()
1246+
if l.err {
1247+
return &ParseError{"", "bad IPSECKEY gateway", l}
1248+
}
1249+
1250+
rr.GatewayAddr, rr.GatewayHost, err = parseAddrHostUnion(l.token, o, rr.GatewayType)
1251+
if err != nil {
1252+
return &ParseError{"", "AMTRELAY " + err.Error(), l}
1253+
}
1254+
1255+
c.Next() // zBlank
1256+
1257+
s, pErr := endingToString(c, "bad IPSECKEY PublicKey")
1258+
if pErr != nil {
1259+
return pErr
1260+
}
1261+
rr.PublicKey = s
1262+
return slurpRemainder(c)
1263+
}
1264+
1265+
func (rr *AMTRELAY) parse(c *zlexer, o string) *ParseError {
1266+
l, _ := c.Next()
1267+
num, err := strconv.ParseUint(l.token, 10, 8)
1268+
if err != nil || l.err {
1269+
return &ParseError{"", "bad AMTRELAY value", l}
1270+
}
1271+
rr.Precedence = uint8(num)
1272+
c.Next() // zBlank
1273+
1274+
l, _ = c.Next()
1275+
if l.err || !(l.token == "0" || l.token == "1") {
1276+
return &ParseError{"", "bad discovery value", l}
1277+
}
1278+
if l.token == "1" {
1279+
rr.GatewayType = 0x80
1280+
}
1281+
1282+
c.Next() // zBlank
1283+
1284+
l, _ = c.Next()
1285+
num, err = strconv.ParseUint(l.token, 10, 8)
1286+
if err != nil || l.err {
1287+
return &ParseError{"", "bad AMTRELAY value", l}
1288+
}
1289+
rr.GatewayType |= uint8(num)
1290+
c.Next() // zBlank
1291+
1292+
l, _ = c.Next()
1293+
if l.err {
1294+
return &ParseError{"", "bad AMTRELAY gateway", l}
1295+
}
1296+
1297+
rr.GatewayAddr, rr.GatewayHost, err = parseAddrHostUnion(l.token, o, rr.GatewayType&0x7f)
1298+
if err != nil {
1299+
return &ParseError{"", "AMTRELAY " + err.Error(), l}
1300+
}
1301+
1302+
return slurpRemainder(c)
1303+
}
1304+
1305+
// same constants and parsing between IPSECKEY and AMTRELAY
1306+
func parseAddrHostUnion(token, o string, gatewayType uint8) (addr net.IP, host string, err error) {
1307+
switch gatewayType {
1308+
case IPSECGatewayNone:
1309+
if token != "." {
1310+
return addr, host, errors.New("gateway type none with gateway set")
1311+
}
1312+
case IPSECGatewayIPv4, IPSECGatewayIPv6:
1313+
addr = net.ParseIP(token)
1314+
if addr == nil {
1315+
return addr, host, errors.New("gateway IP invalid")
1316+
}
1317+
if (addr.To4() == nil) == (gatewayType == IPSECGatewayIPv4) {
1318+
return addr, host, errors.New("gateway IP family mismatch")
1319+
}
1320+
case IPSECGatewayHost:
1321+
var ok bool
1322+
host, ok = toAbsoluteName(token, o)
1323+
if !ok {
1324+
return addr, host, errors.New("invalid gateway host")
1325+
}
1326+
}
1327+
1328+
return addr, host, nil
1329+
}
1330+
12191331
func (rr *RKEY) parse(c *zlexer, o string) *ParseError {
12201332
l, _ := c.Next()
12211333
i, e := strconv.ParseUint(l.token, 10, 16)

0 commit comments

Comments
 (0)