GetTypesToLoad Attribute cant be null (#5054)

SimonCropp · web-flow · commit 02e1cf0fe4bb · 2024-05-23T09:34:15.000+02:00
since it walks the items returned by GetCustomAttributes which will not contain nulls
diff --git a/src/Microsoft.TestPlatform.Common/Utilities/TypesToLoadUtilities.cs b/src/Microsoft.TestPlatform.Common/Utilities/TypesToLoadUtilities.cs
@@ -27,9 +27,6 @@ internal static IEnumerable<Type> GetTypesToLoad(Assembly assembly)
 
     private static IEnumerable<Type> GetTypesToLoad(Attribute attribute)
     {
-        if (attribute == null)
-            return Enumerable.Empty<Type>();
-
         var type = attribute.GetType();
         var typesProperty = type.GetProperty("Types");
 

Original file line number	Diff line number	Diff line change
`@@ -27,9 +27,6 @@ internal static IEnumerable<Type> GetTypesToLoad(Assembly assembly)`
`27`	`27`
`28`	`28`	`private static IEnumerable<Type> GetTypesToLoad(Attribute attribute)`
`29`	`29`	`{`
`30`		`- if (attribute == null)`
`31`		`- return Enumerable.Empty<Type>();`
`32`		`-`
`33`	`30`	`var type = attribute.GetType();`
`34`	`31`	`var typesProperty = type.GetProperty("Types");`
`35`	`32`