Refactors tokenization to support custom background tokenizer. #174364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdima
reviewed
Feb 15, 2023
alexdima
previously approved these changes
Feb 15, 2023
Member
alexdima
left a comment
alexdima
left a comment
There was a problem hiding this comment.
👍 LGTM. I left comments for some small things.
| this._semanticTokens.flush(); | ||
| } | ||
|
|
||
| // TODO@hediet TODO@alexdima what is the difference between this and acceptEdit? |
Member
There was a problem hiding this comment.
👍 I agree that they should be merged, right now acceptEdit only updates tokens and handleDidChangeContent only updates states. Maybe in a separate cleanup PR
alexdima
approved these changes
Feb 15, 2023
c-claeys
pushed a commit
to c-claeys/vscode
that referenced
this pull request
Feb 16, 2023
…ization Refactors tokenization to support custom background tokenizer.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recommend VS Code to review the diff.
@alexdima It would be awesome if you could carefully review this change.
The textmate tokenization feature that builds on this refactoring doesn't need a very careful review, as we can add an experimental setting (default false) for that.