Support pwsh preview error feedback providers #170887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@daxian-dbw a quick review of how this is being matched would be appreciated 🙂 |
meganrogge
reviewed
Jan 9, 2023
src/vs/workbench/contrib/terminal/test/browser/quickFixAddon.test.ts
Outdated
Show resolved
Hide resolved
Member
|
The matching looks good to me. I just realize that you can receive the standard output from an EXE without redirecting the stdout of the EXE, which is very handy 😄 |
Member
Author
|
@daxian-dbw I noticed some not so great results like |
meganrogge
previously approved these changes
Jan 9, 2023
Contributor
meganrogge
left a comment
meganrogge
left a comment
There was a problem hiding this comment.
Just remove the .only and LGTM
Member
Yeah, that's why it's remains an experimental feature (PSCommandNotFoundSuggestion). |
meganrogge
approved these changes
Jan 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170484
I ended up adding both always, it can result in a lot of suggestions but it felt bad not suggesting some of them. We've talked about allow filtering that list before which would be cool here.