Move local terminal processes to live under the new ptyHost process #116373
Conversation
More descriptive as it's for local/electron terminal processes only
This brings in microsoft/node-pty#415 which will finally fix the hang issue on Windows with conpty. Performance on Windows should also improve a lot because node-pty is now hosted outside of the cluttered renderer process. Fixes #71966
Move local ptys to ptyHost under shared process
|
Think I finally figured out the problem now that I can log: |
Worker threads don't appear to play nicely with asar which was causing only the bundled version of VS Code's terminal to break
|
Unfortunately this is going to be merged without the fix to #76548, the problem I've been stuck on for a few days was caused once again by It seems that asar simply does not support resolving lookups in workers based on my own findings and from some searching (eg). So I need to make a minimal repro and create an issue in Electron. There is |
Fixes #74620