Fix tool calls property normalization and stream options handling for non-streaming responses (#1732)

* add log

* try streaming false

* try undefined

* correct fix

* correct fix 2

* fixxxx

* consume resp just once

* fix message

* no replacement of content

* clean up but need to make stream configurable for byok

* update

* update

Author: zhichli

src/extension/byok/node/openAIEndpoint.ts

@@ -296,7 +296,7 @@ export class OpenAIEndpoint extends ChatEndpoint {
 			}
 			// Removing max tokens defaults to the maximum which is what we want for BYOK
 			delete body.max_tokens;
-			if (!this.useResponsesApi) {
+			if (!this.useResponsesApi && body.stream) {
 				body['stream_options'] = { 'include_usage': true };
 			}
 		}

src/platform/endpoint/node/chatEndpoint.ts

@@ -64,7 +64,14 @@ export async function defaultNonStreamChatResponseProcessor(response: Response,
 	const completions: ChatCompletion[] = [];
 	for (let i = 0; i < (jsonResponse?.choices?.length || 0); i++) {
 		const choice = jsonResponse.choices[i];
-		const message: Raw.AssistantChatMessage = choice.message;
+		const message: Raw.AssistantChatMessage = {
+			role: choice.message.role,
+			content: choice.message.content,
+			name: choice.message.name,
+			// Normalize property name: OpenAI API uses snake_case (tool_calls) but our types expect camelCase (toolCalls)
+			// See: https://platform.openai.com/docs/api-reference/chat/object#chat-object-choices-message-tool_calls
+			toolCalls: choice.message.toolCalls ?? choice.message.tool_calls,
+		};
 		const messageText = getTextPart(message.content);
 		const requestId = response.headers.get('X-Request-ID') ?? generateUuid();
 		const ghRequestId = response.headers.get('x-github-request-id') ?? '';