Don't use Readable.wrap #1114
Merged
Don't use Readable.wrap #1114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the recent issues we've been having with zip deploy. Based on the Node.JS docs, I think this fix is OK.
We add a 'data' event listener, so this breaking edge case shouldn't apply to us.I am able to deploy successfully if I replace
new Readable().wrap(zipFile.outputStream)withzipFile.outputStream as Readable.This still could be an issue with yazl, or possibly a bug with Readable.wrap.
Readable.wrap
v15.0.0 is the first version where the issue reproduces. There was a commit that changed the implementation of .wrap in v15.0.0.
PR: nodejs/node#34204
Changelog (search for ".wrap"): https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V15.md#semver-major-commits