Throw OCE from canceled requests even when remote disconnects before sending cancellation acknowledgment #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Associated bug: |
AArnott
requested changes
May 2, 2019
AArnott
reviewed
May 2, 2019
AArnott
reviewed
May 2, 2019
AArnott
changed the title
AArnott
changed the title
AArnott
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After canceling a request, frequently the client gets disposed. In 1.5 this would result in an expected cancelation state. In 2.0 this started throwing a ConnectionLostException if the dispose happened subsequently. Since the lost connection was a result of canceled request and not the cause of it, this adjusts the state of the task to match the expected state.
Tests were added to verify dispose does the expected behavior, as well as a lost connection still results in the ConnectionLostException.
Fixes: #265
@AArnott @tinaschrepfer