Merge pull request #1167 from microsoft/dev/andarno/dropAnalyzers

Drop the vs-threading analyzers from our package

Author: AArnott

Directory.Packages.props

@@ -6,7 +6,7 @@
     <CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
     <MessagePackVersion>2.5.192</MessagePackVersion>
     <MicroBuildVersion>2.0.187</MicroBuildVersion>
-    <VisualStudioThreadingVersion>17.13.2</VisualStudioThreadingVersion>
+    <VisualStudioThreadingVersion>17.14.2-alpha</VisualStudioThreadingVersion>
     <CodeAnalysisAnalyzerVersion>3.11.0-beta1.24629.2</CodeAnalysisAnalyzerVersion>
   </PropertyGroup>
   <ItemGroup>
@@ -18,9 +18,10 @@
     <PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" />
     <PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="$(CodeAnalysisAnalyzerVersion)" />
     <PackageVersion Include="Microsoft.VisualStudio.Threading.Analyzers" Version="$(VisualStudioThreadingVersion)" />
+    <PackageVersion Include="Microsoft.VisualStudio.Threading.Only" Version="$(VisualStudioThreadingVersion)" />
     <PackageVersion Include="Microsoft.VisualStudio.Threading" Version="$(VisualStudioThreadingVersion)" />
     <PackageVersion Include="Microsoft.VisualStudio.Validation" Version="17.8.8" />
-    <PackageVersion Include="Nerdbank.Streams" Version="2.11.79" />
+    <PackageVersion Include="Nerdbank.Streams" Version="2.12.84-alpha" />
     <PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
     <PackageVersion Include="System.Collections.Immutable" Version="8.0.0" />
     <PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="8.0.1" />

doc/vs.md

@@ -33,6 +33,7 @@ When building a Visual Studio extension, you should not include StreamJsonRpc in
 | VS 2022.11 | 1.5.x, 2.19.x
 | VS 2022.12 | 1.5.x, 2.20.x
 | VS 2022.13 | 1.5.x, 2.21.x
+| VS 2022.14 | 1.5.x, 2.22.x
 
 StreamJsonRpc versions are forwards and backwards compatible "over the wire". For example it is perfectly legitimate to use StreamJsonRpc 2.4 on the server-side even if the client only uses 1.0, or vice versa. If an RPC method utilizes a newer StreamJsonRpc feature (e.g. `IAsyncEnumerable<T>` return value) and an older client that doesn't support these specially marshaled objects is used to call that method, a memory leak on the server may result.
 

src/StreamJsonRpc/StreamJsonRpc.csproj

@@ -15,7 +15,8 @@
   <ItemGroup>
     <PackageReference Include="MessagePack" />
     <PackageReference Include="MessagePackAnalyzer" PrivateAssets="all" />
-    <PackageReference Include="Microsoft.VisualStudio.Threading" />
+    <PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" PrivateAssets="all"/>
+    <PackageReference Include="Microsoft.VisualStudio.Threading.Only" />
     <PackageReference Include="Nerdbank.Streams" />
     <PackageReference Include="Newtonsoft.Json" />
     <PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" PrivateAssets="all" />

test/StreamJsonRpc.Tests/DuplexPipeMarshalingTests.cs

@@ -620,49 +620,13 @@ public async Task StreamClosesDeterministically()
         monitoredStream.Disposed += (s, e) => disposedEvent.Set();
 
         bool writing = false;
-        monitoredStream.WillWrite += (s, e) =>
-        {
-            Assert.False(writing);
-            writing = true;
-            this.Logger.WriteLine("Writing {0} bytes.", e.Count);
-        };
-        monitoredStream.WillWriteByte += (s, e) =>
-        {
-            Assert.False(writing);
-            writing = true;
-            this.Logger.WriteLine("Writing 1 byte.");
-        };
-        monitoredStream.WillWriteMemory += (s, e) =>
-        {
-            Assert.False(writing);
-            writing = true;
-            this.Logger.WriteLine("Writing {0} bytes.", e.Length);
-        };
-        monitoredStream.WillWriteSpan += (s, e) =>
+        monitoredStream.WillWriteAny += (s, e) =>
         {
             Assert.False(writing);
             writing = true;
             this.Logger.WriteLine("Writing {0} bytes.", e.Length);
         };
-        monitoredStream.DidWrite += (s, e) =>
-        {
-            Assert.True(writing);
-            writing = false;
-            this.Logger.WriteLine("Wrote {0} bytes.", e.Count);
-        };
-        monitoredStream.DidWriteByte += (s, e) =>
-        {
-            Assert.True(writing);
-            writing = false;
-            this.Logger.WriteLine("Wrote 1 byte.");
-        };
-        monitoredStream.DidWriteMemory += (s, e) =>
-        {
-            Assert.True(writing);
-            writing = false;
-            this.Logger.WriteLine("Wrote {0} bytes.", e.Length);
-        };
-        monitoredStream.DidWriteSpan += (s, e) =>
+        monitoredStream.DidWriteAny += (s, e) =>
         {
             Assert.True(writing);
             writing = false;

version.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://raw.githubusercontent.com/dotnet/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json",
-  "version": "2.21",
+  "version": "2.22-alpha",
   "publicReleaseRefSpec": [
     "^refs/heads/main$",
     "^refs/heads/v\\d+(?:.\\d+)?$"