Browse buttons crash when running as admin

[carlos-zamora]

The optional graphical settings editor worked properly when I ran Windows Terminal as a regular user. However, if I ran Windows Terminal as Administrator, the app would crash if I clicked the "Browse..." button for either "Command line" or "Starting directory".

Originally posted by @huang63 in #6800 (comment)

[carlos-zamora]

Did a bit of digging on this one. Here's my findings:

Relevant PR: #8391

The culprit is this call right here:

terminal/src/cascadia/TerminalSettingsEditor/Profiles.cpp

Line 348 in e7d3262

StorageFolder folder = co_await picker.PickSingleFolderAsync();

I'm not exactly sure what is going on though. Looks like PickSingleFolderAsync() failed, and GetResults() returns a bad HRESULT.

Assigning @DHowett for now to provide some ideas/insight on next steps.

[DHowett]

You’re gonna need to give me that HRESULT!

I’m guessing this is the same class of problem as “i can’t drag tabs in admin mode”. Same team, same APIs...

[WSLUser]

I'm now betting #8950 is extremely related. It didn't matter if it was elevated or not so I think invalid paths are still an issue that likely correlate to this bug. Perhaps they have the same fix (one can hope).