Skip to content

Commit 7423734

Browse files
authored
Update pattern locations again after scrolling (#11059)
This is on me. When I got rid of the `_updatePatternLocations` `ThrottledFunc` in the `TermControl`, I didn't add a matching call to `_updatePatternLocations->Run()` in this method. In #9820, in `TermControl::_ScrollPositionChanged`, there was still a call to `_updatePatternLocations->Run();`. (TermControl.cpp:1655 on the right) https://github.com/microsoft/terminal/pull/9820/files#diff-c10bb023995e88dac6c1d786129284c454c2df739ea547ce462129dc86dc2697R1654 #10051 didn't change this In #10187 I moved the `_updatePatternLocations` throttled func from termcontrol to controlcore. Places it existed before: * [x] `TermControl::_coreReceivedOutput`: already matched by ControlCore::_connectionOutputHandler * [x] `TermControl::_ScrollbarChangeHandler` -> added in c20eb9d * [x] `TermControl::_ScrollPositionChanged` -> `ControlCore::_terminalScrollPositionChanged` ## Validation Steps Performed Print a URL, scroll the wheel: it still works. Closes #11055
1 parent 07dc060 commit 7423734

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/cascadia/TerminalControl/ControlCore.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -414,6 +414,8 @@ namespace winrt::Microsoft::Terminal::Control::implementation
414414
// This is a scroll event that wasn't initiated by the terminal
415415
// itself - it was initiated by the mouse wheel, or the scrollbar.
416416
_terminal->UserScrollViewport(viewTop);
417+
418+
_updatePatternLocations->Run();
417419
}
418420

419421
void ControlCore::AdjustOpacity(const double adjustment)

0 commit comments

Comments
 (0)