feat: expire stale advanced metrics after not being updated for some time #1921
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With advanced metrics, high-cardinality labels can cause the metrics export to bloat leading to unbounded memory and resource usage.
This PR sets up an optional TTL for advanced metrics defined in the
MetricsConfigurationCRD. By default, the TTL is infinite and cleanup is not tracked or done.When defined, on a period equal to the TTL metrics which have not been updated within the last TTL duration will be removed from the metrics export.
For counters and gauges that look like counters, this will be treated by Prometheus similar to any other missing metric (for example from an application restart). As long as functions like
rateorincreaseare used, calculations will remain accurate.Related Issue
#1692
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Deployed, modified CRD to enable/disable and change the TTL.
Metrics are re-initialized as expected.
Made sure that CRD validation rejects invalid TTL values.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.