From a4cf7a7ec2ae2f2a8b58f7b5ec2e77646e7d99fc Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 23 Sep 2025 06:41:49 +0000 Subject: [PATCH 1/2] Initial plan From e809d42711431f4d45c1bb7a2cd42cbdd7ee34f4 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 23 Sep 2025 06:48:31 +0000 Subject: [PATCH 2/2] Fix ScrollView pageUp/pageDown using wrong dimension for horizontal scrolling Co-authored-by: anupriya13 <54227869+anupriya13@users.noreply.github.com> --- .../Fabric/Composition/ScrollViewComponentView.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vnext/Microsoft.ReactNative/Fabric/Composition/ScrollViewComponentView.cpp b/vnext/Microsoft.ReactNative/Fabric/Composition/ScrollViewComponentView.cpp index 41946935277..db84cf6d2eb 100644 --- a/vnext/Microsoft.ReactNative/Fabric/Composition/ScrollViewComponentView.cpp +++ b/vnext/Microsoft.ReactNative/Fabric/Composition/ScrollViewComponentView.cpp @@ -1056,14 +1056,14 @@ bool ScrollViewComponentView::scrollToStart(bool animate) noexcept { bool ScrollViewComponentView::pageUp(bool animate) noexcept { if (std::static_pointer_cast(viewProps())->horizontal) { - return scrollLeft(m_layoutMetrics.frame.size.height * m_layoutMetrics.pointScaleFactor, animate); + return scrollLeft(m_layoutMetrics.frame.size.width * m_layoutMetrics.pointScaleFactor, animate); } return scrollUp(m_layoutMetrics.frame.size.height * m_layoutMetrics.pointScaleFactor, animate); } bool ScrollViewComponentView::pageDown(bool animate) noexcept { if (std::static_pointer_cast(viewProps())->horizontal) { - return scrollRight(m_layoutMetrics.frame.size.height * m_layoutMetrics.pointScaleFactor, animate); + return scrollRight(m_layoutMetrics.frame.size.width * m_layoutMetrics.pointScaleFactor, animate); } return scrollDown(m_layoutMetrics.frame.size.height * m_layoutMetrics.pointScaleFactor, animate); }