feat(android): Add ability to configure key store - #692
Merged
Conversation
sveinar
requested review from
arazabishov,
sweggersen and
tido64
as code owners
January 6, 2022 23:17
The ability to configure the key store is required for enabling certain features such as MSAL's auth broker.
sveinar
force-pushed
the
sveinar/android_keystore
branch
from
January 7, 2022 07:55
258216f to
596eecd
Compare
tido64
reviewed
Jan 7, 2022
tido64
left a comment
tido64
left a comment
Member
There was a problem hiding this comment.
This looks great! Just a few nitpicks and it will be good to go.
tido64
reviewed
Jan 7, 2022
tido64
reviewed
Jan 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ability to configure the key store is required for enabling certain features such as MSAL's auth broker.
Description
We need to add signingConfigs property to the Android specific section in the app manifest.
I tried as much to match the DSL of the app manifest itself.
In the code, I have 'landed' on a fixed set of flavors, debug and release.
The trouble to make this generic on the fly in the 'android' section of the gradle is that the signingConfigs are ReadOnly object when first created. If I tried to use closures inside the 'android' section with .each { flavor -> ... } then there was a mismatch with the closure and the DSL, even if I tried to use a proper Java class for the SigningConfig. Alas, two flavors for now.
Resolves #691.
Platforms affected
Test plan
Tested with overwriting the 'debug' flavor using a debug.keystore.
Tested with a release keystore.
Tested without any signingConfig in the app.json.
Tested with signingConfig with a
TODO