Fixed bug that causes a false negative when using unquoted types in a TypedDict functional class definition if the types are forward declared. This addresses #10612. (#10869)

Author: erictraut

packages/pyright-internal/src/analyzer/typeEvaluator.ts

@@ -21696,7 +21696,7 @@ export function createTypeEvaluator(
         }
 
         const fileInfo = AnalyzerNodeInfo.getFileInfo(node);
-        if (isAnnotationEvaluationPostponed(fileInfo) || options?.forwardRefs) {
+        if ((isAnnotationEvaluationPostponed(fileInfo) || options?.forwardRefs) && !options?.runtimeTypeExpression) {
             flags |= EvalFlags.ForwardRefs;
         } else if (options?.parsesStringLiteral) {
             flags |= EvalFlags.ParsesStringLiteral;
@@ -22460,6 +22460,7 @@ export function createTypeEvaluator(
                                 allowFinal: true,
                                 allowRequired: true,
                                 allowReadOnly: true,
+                                runtimeTypeExpression: true,
                             }).type
                         );
                     } else {

packages/pyright-internal/src/analyzer/typeEvaluatorTypes.ts

@@ -404,6 +404,7 @@ export interface ExpectedTypeOptions {
     typeFormArg?: boolean;
     forwardRefs?: boolean;
     typeExpression?: boolean;
+    runtimeTypeExpression?: boolean;
     convertEllipsisToAny?: boolean;
     allowEllipsis?: boolean;
 }

packages/pyright-internal/src/tests/samples/typedDict6.py

@@ -81,3 +81,17 @@ def foo(unknown_str_value: str):
 # This should generate an error because the name doesn't match.
 # the arguments are missing.
 Movie13 = TypedDict("NotMovie13", {"name": str, "year": int})
+
+
+# This should generate an error because CustomType1 is a forward reference
+# and is not quoted.
+Movie14 = TypedDict("Movie14", {"title": CustomType1, "year": "CustomType2"})
+
+# This should generate an error because CustomType2 is a forward reference
+# and is not quoted.
+Movie15 = TypedDict("Movie15", title="CustomType1", year=CustomType2)
+
+
+class CustomType1: ...
+class CustomType2: ...
+

packages/pyright-internal/src/tests/typeEvaluator7.test.ts

@@ -673,7 +673,7 @@ test('TypedDict5', () => {
 test('TypedDict6', () => {
     const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDict6.py']);
 
-    TestUtils.validateResults(analysisResults, 13);
+    TestUtils.validateResults(analysisResults, 15);
 });
 
 test('TypedDict7', () => {