Skip to content

Use Audience in LivePresence for setting online/offline state #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 13, 2024
Merged

Use Audience in LivePresence for setting online/offline state #790

merged 11 commits into from
Aug 13, 2024

Conversation

@huntj88
Copy link
Contributor

@huntj88 huntj88 commented Jul 29, 2024 •
edited
Loading

  • Use Audience in LivePresence for setting online/offline state of each connection.
  • LivePresenceUser aggregates connection state from all of its connections.
  • Used the old expire logic to set state to away
  • Remove ability for dev to set connection status, but added comment showing how to set expiration time for away state.
  • Deleted old workaround code in LivePresence.

ryanbliss
ryanbliss approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@ryanbliss ryanbliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just make the change with the generic type we discussed and we should be good to go!

@huntj88 huntj88 merged commit 811ee43 into mainv2 Aug 13, 2024
@huntj88 huntj88 deleted the jameshunt/presence-with-audience-state branch August 13, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryanbliss ryanbliss ryanbliss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huntj88 @ryanbliss