Skip to content

Cleanup Live Share folder structure #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 1, 2024
Merged

Cleanup Live Share folder structure #782

merged 7 commits into from
Jul 1, 2024

Conversation

@huntj88
Copy link
Contributor

@huntj88 huntj88 commented Jul 1, 2024 •
edited
Loading

  • Changed the way internal file are exposed
    image
  • Deleted LiveEventTimer because it was hard to use as it relied on the user knowing how internal constructs work. It was also not helpful internally.
  • Deleted index.ts in internal package.
  • Moved several files and their tests into the internal folder.
image image

@huntj88 huntj88 marked this pull request as ready for review July 1, 2024 17:42
huntj88
huntj88 commented Jul 1, 2024
View reviewed changes
packages/live-share-media/src/internals/GroupCoordinatorState.ts
} from "./GroupPlaybackTrackData";
import { TelemetryEvents } from "./consts";
import { waitUntilConnected } from "@microsoft/live-share/bin/internals";
import { waitUntilConnected } from "@microsoft/live-share/bin/internals/utils";
Copy link
Contributor Author

@huntj88 huntj88 Jul 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we export waitUntilConnected? it has the hidden annotation already.

Same question for any resource referencing bin or src?

src one might be okay, because only used in unit tests after my changes

@huntj88 huntj88 force-pushed the jameshunt/cleanup-v2 branch from 6603143 to 6fc6ec1 Compare July 1, 2024 20:16
ryanbliss
ryanbliss approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@ryanbliss ryanbliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huntj88 huntj88 merged commit bbde862 into mainv2 Jul 1, 2024
@huntj88 huntj88 deleted the jameshunt/cleanup-v2 branch July 1, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryanbliss ryanbliss ryanbliss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huntj88 @ryanbliss