Skip to content

Commit ac366c8

Browse files
authored
Added video js sample (#801)
1 parent 6b0babb commit ac366c8

File tree

82 files changed

+5526
-131
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

82 files changed

+5526
-131
lines changed

package-lock.json

Lines changed: 1107 additions & 78 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/live-share-react/src/live-hooks/useLiveCanvas.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ export function ExampleLiveCanvas() {
8989
export function useLiveCanvas(
9090
uniqueKey: string,
9191
canvasElementRef: React.RefObject<HTMLElement | null> | string,
92-
props: IUseLiveCanvasOptionalProps
92+
props?: IUseLiveCanvasOptionalProps
9393
): IUseLiveCanvasResults {
9494
/**
9595
* User facing: inking manager instance

samples/javascript/01.dice-roller/README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,11 @@ After cloning the repository, you must first set up the npm workspace from the r
1313

1414
```bash
1515
npm install
16-
npm run build:packages # Build Live Share packages
1716
cd samples/j*/01*
18-
npm start
1917
```
2018

2119
Running `npm start`, it will do two things: start the `tinylicious` server and start the application using `vite`. If you have never used `tinylicious` before, you should see instead is a prompt saying `Ok to proceed? (y)`, after which you should type `y` and press the "enter" key. In rare cases you might not see the `Ok to proceed? (y)` prompt, in which case try running `npx tinylicious@latest` in your command line directly, and then try again.
2220

23-
_Note:_ Do not run `npm start` before running `npm run build:packages` from the root of the project, unless you first move the sample out of this npm workspace. When using our samples, you are testing the packages using symlinks, and not the Live Share SDK versions published to npm.
24-
2521
## Testing the app in Teams
2622

2723
### Create a ngrok tunnel to allow Teams to reach your tab app

samples/javascript/02.react-video/README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,9 @@ After cloning the repository, you must first set up the npm workspace from the r
88

99
```bash
1010
npm install
11-
npm run build:packages # Build Live Share packages
1211
cd samples/j*/02*
1312
```
1413

15-
_Note:_ Do not run `npm start` before running `npm run build:packages` from the root of the project, unless you first move the sample out of this npm workspace. When using our samples, you are testing the packages using symlinks, and not the Live Share SDK versions published to npm.
16-
1714
## Testing locally in browser
1815

1916
### `npm run start`

samples/javascript/03.live-canvas-demo/README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,9 @@ After cloning the repository, you must first set up the npm workspace from the r
88

99
```bash
1010
npm install
11-
npm run build:packages # Build Live Share packages
1211
cd samples/j*/03*
1312
```
1413

15-
_Note:_ Do not run `npm start` before running `npm run build:packages` from the root of the project, unless you first move the sample out of this npm workspace. When using our samples, you are testing the packages using symlinks, and not the Live Share SDK versions published to npm.
16-
1714
## Testing locally in browser
1815

1916
### `npm run start`

samples/javascript/04.live-share-react/README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,9 @@ After cloning the repository, you must first set up the npm workspace from the r
1010

1111
```bash
1212
npm install
13-
npm run build:packages # Build Live Share packages
1413
cd samples/j*/04*
1514
```
1615

17-
_Note:_ Do not run `npm start` before running `npm run build:packages` from the root of the project, unless you first move the sample out of this npm workspace. When using our samples, you are testing the packages using symlinks, and not the Live Share SDK versions published to npm.
18-
1916
## Testing locally in browser
2017

2118
### `npm run start`

samples/javascript/05.dice-roller-turbo/README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,9 @@ After cloning the repository, you must first set up the npm workspace from the r
1212

1313
```bash
1414
npm install
15-
npm run build:packages # Build Live Share packages
1615
cd samples/j*/05*
1716
```
1817

19-
_Note:_ Do not run `npm start` before running `npm run build:packages` from the root of the project, unless you first move the sample out of this npm workspace. When using our samples, you are testing the packages using symlinks, and not the Live Share SDK versions published to npm.
20-
2118
## Testing locally in browser
2219

2320
### `npm run start`

samples/javascript/21.react-media-template/README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,9 @@ After cloning the repository, you must first set up the npm workspace from the r
1313

1414
```bash
1515
npm install
16-
npm run build:packages # Build Live Share packages
1716
cd samples/j*/21*
1817
```
1918

20-
_Note:_ Do not run `npm start` before running `npm run build:packages` from the root of the project, unless you first move the sample out of this npm workspace. When using our samples, you are testing the packages using symlinks, and not the Live Share SDK versions published to npm.
21-
2219
## Testing locally in browser
2320

2421
### `npm run start`

samples/javascript/22.react-agile-poker/README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,9 @@ After cloning the repository, you must first set up the npm workspace from the r
1212

1313
```bash
1414
npm install
15-
npm run build:packages # Build Live Share packages
1615
cd samples/j*/22*
1716
```
1817

19-
_Note:_ Do not run `npm start` before running `npm run build:packages` from the root of the project, unless you first move the sample out of this npm workspace. When using our samples, you are testing the packages using symlinks, and not the Live Share SDK versions published to npm.
20-
2118
## Testing locally in browser
2219

2320
### `npm run start`

samples/javascript/23.react-live-canvas/README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,9 @@ After cloning the repository, you must first set up the npm workspace from the r
1717

1818
```bash
1919
npm install
20-
npm run build:packages # Build Live Share packages
2120
cd samples/j*/22*
2221
```
2322

24-
_Note:_ Do not run `npm start` before running `npm run build:packages` from the root of the project, unless you first move the sample out of this npm workspace. When using our samples, you are testing the packages using symlinks, and not the Live Share SDK versions published to npm.
25-
2623
## Testing locally in browser
2724

2825
### `npm run start`

0 commit comments

Comments
 (0)