resolve comments

Author: ultmaster

.github/workflows/tests.yml

@@ -41,6 +41,7 @@ jobs:
             --group torch-cpu \
             --group torch-stable \
             --group trl \
+            --group tinker \
             --group agents \
             --no-default-groups
         if: matrix.setup == 'slow'

examples/tinker/agl_tinker/env.py

@@ -248,8 +248,9 @@ async def __call__(self) -> tuple[AGLDataset[T_task], AGLDataset[T_task]]:
                 len(train_indices),
                 len(val_indices),
             )
-            train_dataset = [train_dataset[i] for i in train_indices]
-            val_dataset = [train_dataset[i] for i in val_indices]
+            splitted_train_dataset = [train_dataset[i] for i in train_indices]
+            splitted_val_dataset = [train_dataset[i] for i in val_indices]
+            train_dataset, val_dataset = splitted_train_dataset, splitted_val_dataset
 
         return (
             AGLDataset(

examples/tinker/hello.py

@@ -86,8 +86,6 @@ def hello(task: str, llm: agl.LLM, rollout: agl.Rollout) -> None:
         rew = 1.0
     elif ("not " + task) in content_lower:
         rew = -1.0
-    elif ("you're" + task) in content_lower or ("you are" + task) in content_lower:
-        rew = 0.1
     else:
         rew = 0.0