fix(47597): preProcessFile incorrectly identifies imports in comments after a template literal type #47657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielRosenwasser
requested changes
Feb 18, 2022
a-tarasyuk
force-pushed
the
fix/47597
branch
from
889b710 to
097e2a5
Compare
a-tarasyuk
force-pushed
the
fix/47597
branch
from
097e2a5 to
213dbe1
Compare
typescript-bot
added
For Milestone Bug
a-tarasyuk
force-pushed
the
fix/47597
branch
from
213dbe1 to
e41f88a
Compare
a-tarasyuk
force-pushed
the
fix/47597
branch
from
e41f88a to
e1bf7cf
Compare
DanielRosenwasser
approved these changes
Mar 11, 2022
Member
|
@typescript-bot cherry-pick this to release-4.6 |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
Member
|
@typescript-bot pack this |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 4516fa8. You can monitor the build here. |
Collaborator
|
Hey @DanielRosenwasser, I've opened #48223 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Mar 11, 2022
Component commits: 4516fa8 fix(47597): ignore commented imports following template expression
Collaborator
|
Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running |
andrewbranch
approved these changes
Mar 15, 2022
DanielRosenwasser
pushed a commit
that referenced
this pull request
Mar 16, 2022
Component commits: 4516fa8 fix(47597): ignore commented imports following template expression Co-authored-by: Oleksandr T <[email protected]>
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Mar 27, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [typescript](https://www.typescriptlang.org/) ([source](https://github.com/Microsoft/TypeScript)) | devDependencies | minor | [`4.5.5` -> `4.6.3`](https://renovatebot.com/diffs/npm/typescript/4.5.5/4.6.3) | --- ### Release Notes <details> <summary>Microsoft/TypeScript</summary> ### [`v4.6.3`](https://github.com/Microsoft/TypeScript/releases/v4.6.3) [Compare Source](microsoft/TypeScript@v4.6.2...v4.6.3) This release includes fixes for - [an incremental parsing bug caused by faulty error recovery logic](microsoft/TypeScript#47895) - [improved results from the TypeScript API's `preProcessFile` function](microsoft/TypeScript#47657) For the complete list of fixed issues, check out the - [fixed issues query for Typescript 4.6.0 (Beta)](https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.6.0%22+). - [fixed issues query for Typescript 4.6.1 (RC)](https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.6.1%22+). - [fixed issues query for Typescript 4.6.2 (Stable)](https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.6.2%22+). - [fixed issues query for Typescript 4.6.3 (Stable)](https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.6.3%22+). Downloads are available on: - [npm](https://www.npmjs.com/package/typescript) ### [`v4.6.2`](https://github.com/Microsoft/TypeScript/releases/v4.6.2) [Compare Source](microsoft/TypeScript@v4.5.5...v4.6.2) For release notes, check out the [release announcement](https://devblogs.microsoft.com/typescript/announcing-typescript-4-6/). For the complete list of fixed issues, check out the - [fixed issues query for Typescript 4.6.0 (Beta)](https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.6.0%22+). - [fixed issues query for Typescript 4.6.1 (RC)](https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.6.1%22+). - [fixed issues query for Typescript 4.6.2 (Stable)](https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.6.2%22+). Downloads are available on: - [npm](https://www.npmjs.com/package/typescript) - [Visual Studio 2022/2019](https://marketplace.visualstudio.com/items?itemName=TypeScriptTeam.TypeScript-46) ([Select new version in project options](https://github.com/Microsoft/TypeScript/wiki/Updating-TypeScript-in-Visual-Studio-2017)) - [NuGet package](https://www.nuget.org/packages/Microsoft.TypeScript.MSBuild) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1242 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47597
Fixes #30878