Skip to content

Commit f47e5e1

Browse files
Renames WavefrontOtelSpanHandler to WavefrontOtelSpanExporter (#101)
1 parent ee4e697 commit f47e5e1

File tree

2 files changed

+20
-20
lines changed
  • micrometer-tracing-reporters/micrometer-tracing-reporter-wavefront/src/main/java/io/micrometer/tracing/reporter/wavefront
  • micrometer-tracing-tests/micrometer-tracing-integration-test/src/main/java/io/micrometer/tracing/test/reporter/wavefront

2 files changed

+20
-20
lines changed
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,29 +15,29 @@
1515
*/
1616
package io.micrometer.tracing.reporter.wavefront;
1717

18-
import java.util.Collection;
19-
2018
import io.micrometer.tracing.TraceContext;
2119
import io.micrometer.tracing.otel.bridge.OtelFinishedSpan;
2220
import io.opentelemetry.sdk.common.CompletableResultCode;
2321
import io.opentelemetry.sdk.trace.data.SpanData;
2422
import io.opentelemetry.sdk.trace.export.SpanExporter;
2523

24+
import java.util.Collection;
25+
2626
/**
2727
* A {@link SpanExporter} that sends spans to Wavefront.
2828
*
2929
* @author Marcin Grzejszczak
3030
* @since 1.0.0
3131
*/
32-
public class WavefrontOtelSpanHandler implements SpanExporter {
32+
public class WavefrontOtelSpanExporter implements SpanExporter {
3333

3434
private final WavefrontSpanHandler spanHandler;
3535

3636
/**
37-
* Creates a new instance of {@link WavefrontOtelSpanHandler}.
37+
* Creates a new instance of {@link WavefrontOtelSpanExporter}.
3838
* @param spanHandler wavefront span handler
3939
*/
40-
public WavefrontOtelSpanHandler(WavefrontSpanHandler spanHandler) {
40+
public WavefrontOtelSpanExporter(WavefrontSpanHandler spanHandler) {
4141
this.spanHandler = spanHandler;
4242
}
4343

micrometer-tracing-tests/micrometer-tracing-integration-test/src/main/java/io/micrometer/tracing/test/reporter/wavefront/WavefrontOtelSetup.java

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
import io.micrometer.tracing.otel.bridge.OtelPropagator;
5151
import io.micrometer.tracing.otel.bridge.OtelTracer;
5252
import io.micrometer.tracing.propagation.Propagator;
53-
import io.micrometer.tracing.reporter.wavefront.WavefrontOtelSpanHandler;
53+
import io.micrometer.tracing.reporter.wavefront.WavefrontOtelSpanExporter;
5454
import io.micrometer.tracing.reporter.wavefront.WavefrontSpanHandler;
5555
import io.micrometer.tracing.test.reporter.BuildingBlocks;
5656
import io.opentelemetry.api.trace.Tracer;
@@ -120,7 +120,7 @@ public static class Builder {
120120

121121
private Function<MeterRegistry, WavefrontSpanHandler> wavefrontSpanHandler;
122122

123-
private Function<WavefrontOtelSpanHandler, SdkTracerProvider> sdkTracerProvider;
123+
private Function<WavefrontOtelSpanExporter, SdkTracerProvider> sdkTracerProvider;
124124

125125
private Function<SdkTracerProvider, OpenTelemetrySdk> openTelemetrySdk;
126126

@@ -154,7 +154,7 @@ public Builder(String server, String token) {
154154
@SuppressWarnings("rawtypes")
155155
public static class OtelBuildingBlocks implements BuildingBlocks {
156156

157-
private final WavefrontOtelSpanHandler wavefrontOTelSpanHandler;
157+
private final WavefrontOtelSpanExporter wavefrontOTelSpanExporter;
158158

159159
private final OtelTracer otelTracer;
160160

@@ -170,19 +170,19 @@ public static class OtelBuildingBlocks implements BuildingBlocks {
170170

171171
/**
172172
* Creates a new instance of {@link OtelBuildingBlocks}.
173-
* @param wavefrontOTelSpanHandler span handler
173+
* @param wavefrontOTelSpanExporter span handler
174174
* @param otelTracer otel tracer
175175
* @param propagator otel propagator
176176
* @param httpServerHandler otel http server handler
177177
* @param httpClientHandler otel http client handler
178178
* @param customizers observation customizers
179179
* @param arrayListSpanProcessor array list span processor
180180
*/
181-
public OtelBuildingBlocks(WavefrontOtelSpanHandler wavefrontOTelSpanHandler, OtelTracer otelTracer,
181+
public OtelBuildingBlocks(WavefrontOtelSpanExporter wavefrontOTelSpanExporter, OtelTracer otelTracer,
182182
OtelPropagator propagator, HttpServerHandler httpServerHandler, HttpClientHandler httpClientHandler,
183183
BiConsumer<BuildingBlocks, Deque<ObservationHandler<? extends Observation.Context>>> customizers,
184184
ArrayListSpanProcessor arrayListSpanProcessor) {
185-
this.wavefrontOTelSpanHandler = wavefrontOTelSpanHandler;
185+
this.wavefrontOTelSpanExporter = wavefrontOTelSpanExporter;
186186
this.otelTracer = otelTracer;
187187
this.propagator = propagator;
188188
this.httpServerHandler = httpServerHandler;
@@ -269,7 +269,7 @@ public Builder wavefrontSpanHandler(Function<MeterRegistry, WavefrontSpanHandler
269269
* @param sdkTracerProvider sdk tracer provider function
270270
* @return this for chaining
271271
*/
272-
public Builder sdkTracerProvider(Function<WavefrontOtelSpanHandler, SdkTracerProvider> sdkTracerProvider) {
272+
public Builder sdkTracerProvider(Function<WavefrontOtelSpanExporter, SdkTracerProvider> sdkTracerProvider) {
273273
this.sdkTracerProvider = sdkTracerProvider;
274274
return this;
275275
}
@@ -364,11 +364,11 @@ public Builder closingFunction(Consumer<Builder.OtelBuildingBlocks> closingFunct
364364
*/
365365
public WavefrontOtelSetup register(ObservationRegistry observationRegistry, MeterRegistry meterRegistry) {
366366
WavefrontSpanHandler wavefrontSpanHandler = wavefrontSpanHandlerOrMock(meterRegistry);
367-
WavefrontOtelSpanHandler wavefrontOTelSpanHandler = wavefrontOtelSpanHandler(wavefrontSpanHandler);
367+
WavefrontOtelSpanExporter wavefrontOTelSpanExporter = wavefrontOtelSpanHandler(wavefrontSpanHandler);
368368
ArrayListSpanProcessor arrayListSpanProcessor = new ArrayListSpanProcessor();
369369
SdkTracerProvider sdkTracerProvider = this.sdkTracerProvider != null
370-
? this.sdkTracerProvider.apply(wavefrontOTelSpanHandler)
371-
: sdkTracerProvider(wavefrontOTelSpanHandler, arrayListSpanProcessor);
370+
? this.sdkTracerProvider.apply(wavefrontOTelSpanExporter)
371+
: sdkTracerProvider(wavefrontOTelSpanExporter, arrayListSpanProcessor);
372372
OpenTelemetrySdk openTelemetrySdk = this.openTelemetrySdk != null
373373
? this.openTelemetrySdk.apply(sdkTracerProvider) : openTelemetrySdk(sdkTracerProvider);
374374
io.opentelemetry.api.trace.Tracer tracer = this.tracer != null ? this.tracer.apply(openTelemetrySdk)
@@ -381,7 +381,7 @@ public WavefrontOtelSetup register(ObservationRegistry observationRegistry, Mete
381381
? this.httpServerHandler.apply(openTelemetrySdk) : httpServerHandler(openTelemetrySdk);
382382
HttpClientHandler httpClientHandler = this.httpClientHandler != null
383383
? this.httpClientHandler.apply(openTelemetrySdk) : httpClientHandler(openTelemetrySdk);
384-
OtelBuildingBlocks otelBuildingBlocks = new OtelBuildingBlocks(wavefrontOTelSpanHandler, otelTracer,
384+
OtelBuildingBlocks otelBuildingBlocks = new OtelBuildingBlocks(wavefrontOTelSpanExporter, otelTracer,
385385
new OtelPropagator(propagators(Collections.singletonList(B3Propagator.injectingMultiHeaders())),
386386
tracer),
387387
httpServerHandler, httpClientHandler, customizers, arrayListSpanProcessor);
@@ -414,11 +414,11 @@ private WavefrontSpanHandler wavefrontSpanHandler(MeterRegistry meterRegistry) {
414414
new ApplicationTags.Builder(this.applicationName, this.serviceName).build(), new HashSet<>());
415415
}
416416

417-
private static WavefrontOtelSpanHandler wavefrontOtelSpanHandler(WavefrontSpanHandler handler) {
418-
return new WavefrontOtelSpanHandler(handler);
417+
private static WavefrontOtelSpanExporter wavefrontOtelSpanHandler(WavefrontSpanHandler handler) {
418+
return new WavefrontOtelSpanExporter(handler);
419419
}
420420

421-
private static SdkTracerProvider sdkTracerProvider(WavefrontOtelSpanHandler spanHandler,
421+
private static SdkTracerProvider sdkTracerProvider(WavefrontOtelSpanExporter spanHandler,
422422
ArrayListSpanProcessor arrayListSpanProcessor) {
423423
return SdkTracerProvider.builder().setSampler(io.opentelemetry.sdk.trace.samplers.Sampler.alwaysOn())
424424
.addSpanProcessor(arrayListSpanProcessor).addSpanProcessor(SimpleSpanProcessor.create(spanHandler))
@@ -452,7 +452,7 @@ private static HttpClientHandler httpClientHandler(OpenTelemetrySdk openTelemetr
452452

453453
private static Consumer<OtelBuildingBlocks> closingFunction() {
454454
return deps -> {
455-
WavefrontOtelSpanHandler reporter = deps.wavefrontOTelSpanHandler;
455+
WavefrontOtelSpanExporter reporter = deps.wavefrontOTelSpanExporter;
456456
reporter.flush();
457457
reporter.close();
458458
};

0 commit comments

Comments
 (0)