Skip to content

Commit 69086ca

Browse files
committed
Address review feedback
1 parent d8319d0 commit 69086ca

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

benchmarks/benchmarks-core/src/jmh/java/io/micrometer/benchmark/BenchmarkSupport.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616
package io.micrometer.benchmark;
1717

18-
import io.micrometer.common.lang.Nullable;
18+
import org.jspecify.annotations.Nullable;
1919
import org.openjdk.jmh.annotations.Mode;
2020
import org.openjdk.jmh.profile.GCProfiler;
2121
import org.openjdk.jmh.profile.LinuxPerfAsmProfiler;
@@ -204,7 +204,7 @@ public static ChainedOptionsBuilder defaults() {
204204
.warmupTime(new TimeValue(5L, TimeUnit.SECONDS))
205205
// 9.5m benchmarks
206206
.measurementIterations(57)
207-
.measurementTime(new TimeValue(5L, TimeUnit.SECONDS))
207+
.measurementTime(new TimeValue(10L, TimeUnit.SECONDS))
208208
.mode(Mode.AverageTime)
209209
.timeUnit(TimeUnit.NANOSECONDS)
210210
.shouldDoGC(true)

benchmarks/benchmarks-core/src/jmh/java/io/micrometer/benchmark/core/instrument/config/filter/MeterFilterCommonTagsBenchmark.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public class MeterFilterCommonTagsBenchmark {
5151
public int supplied;
5252

5353
@Param({ "0", "1", "2", "4", "8", "16", "32", "64" })
54-
public int ignored;
54+
public int commonTagCount;
5555

5656
private Meter.Id[] samples;
5757

@@ -65,7 +65,7 @@ public class MeterFilterCommonTagsBenchmark {
6565
public void setUp() {
6666
samples = FilterBenchmarkSupport.distributed(supplied).limit(COUNT).toArray(Meter.Id[]::new);
6767

68-
instances = TagsBenchmarkSupport.containers(ignored)
68+
instances = TagsBenchmarkSupport.containers(commonTagCount)
6969
// Using List and not Tags to simulate the worst case
7070
// scenario. We're most interested in saving the performance
7171
// where it suffers most.

benchmarks/benchmarks-core/src/jmh/java/io/micrometer/benchmark/core/instrument/config/filter/MeterFilterIgnoreTagsBenchmark.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,10 @@
2626
import java.util.concurrent.TimeUnit;
2727

2828
/**
29-
* Evaluates performance of {@link MeterFilter#commonTags(Iterable)}. To simulate at least
30-
* a somewhat realistic scenario and prevent false JIT assumptions, the input identifiers
31-
* have an arbitrary number of tags (0 to 64), having a prominent mode of [supplied].
29+
* Evaluates performance of {@link MeterFilter#ignoreTags(String...)}. To simulate at
30+
* least a somewhat realistic scenario and prevent false JIT assumptions, the input
31+
* identifiers have an arbitrary number of tags (0 to 64), having a prominent mode of
32+
* [supplied].
3233
*/
3334
// Use jvmArgsAppend = "-XX:CompileCommand=dontinline,*.Tags.*" and
3435
// similar wildcards if you need to check clean assembly output

0 commit comments

Comments
 (0)